Make the narrow version of the Android Incognito NTP follow the spec

Make the narrow version of the Android Incognito NTP follow the spec

This CL contains improvements of the new Incognito NTP on Android.

1. Bulletpoints: Added the bulletpoint symbol (U+2022), stripped extra
   leading and trailing whitespace.

2. Layout: Updated layout gravity, color, line spacing in the XML file.
   The rest of the layout depends on the tab size, and is thus generated
   programatically in onMeasure().

After these changes, the narrow (width <= 720dp) versions of the NTP
match the spec:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI/files/MCGdLyvs6-fT_lDwU79t-Y5B

This CL does NOT yet contain the wide screen layout (width > 720dp)
which places the two sets of bulletpoints next to each other.

BUG=693525
Review-Url: https://codereview.chromium.org/2933903002
Cr-Commit-Position: refs/heads/master@{#478989}
Committed: https://chromium.googlesource.com/chromium/src/+/42b293e0d826de47c6ecd71774a41f1be37143eb

[msramek, 2017-06-12 17:59:06]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 17:59:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 19:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 19:00:46]

Dry run: This issue passed the CQ dry run.

[msramek, 2017-06-12 19:21:38]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 19:22:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-06-12 19:27:57]

msramek@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[msramek, 2017-06-12 19:27:58]

Hi Michael,

please have a look! Next iteration of the new Incognito NTP design. As before, I
attached screenshots to the linked bug.

Thanks!
Martin

[commit-bot: I haz the power, 2017-06-12 20:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:13:36]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2017-06-13 10:17:49]

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java
(right):

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:31:
private Context mContext;
nit: this can be final

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:32:
private DisplayMetrics mMetrics;
nit: this can be final

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:95:
reflowLayout();
In my experience, the onMeasure method is called very often. Please optimize
this to not call reflowLayout if there has been no change to width or height.

[msramek, 2017-06-13 11:34:16]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 11:34:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-06-13 11:35:31]

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java
(right):

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:31:
private Context mContext;
On 2017/06/13 10:17:49, Michael van Ouwerkerk wrote:
> nit: this can be final

Done.

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:32:
private DisplayMetrics mMetrics;
On 2017/06/13 10:17:49, Michael van Ouwerkerk wrote:
> nit: this can be final

Done.

https://codereview.chromium.org/2933903002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:95:
reflowLayout();
On 2017/06/13 10:17:49, Michael van Ouwerkerk wrote:
> In my experience, the onMeasure method is called very often. Please optimize
> this to not call reflowLayout if there has been no change to width or height.

Done. Good point!

[Michael van Ouwerkerk, 2017-06-13 12:12:32]

lgtm

[commit-bot: I haz the power, 2017-06-13 12:22:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 12:22:43]

Dry run: This issue passed the CQ dry run.

[msramek, 2017-06-13 12:52:32]

Thank you!

[msramek, 2017-06-13 12:53:46]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-06-13 12:54:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 12:58:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497358426260530,
"parent_rev": "f3017f051032150a9bbcd75dbfb371d21ab3abdb", "commit_rev":
"42b293e0d826de47c6ecd71774a41f1be37143eb"}

[commit-bot: I haz the power, 2017-06-13 12:58:46]

Description was changed from

==========
Make the narrow version of the Android Incognito NTP follow the spec

This CL contains improvements of the new Incognito NTP on Android.

1. Bulletpoints: Added the bulletpoint symbol (U+2022), stripped extra
   leading and trailing whitespace.

2. Layout: Updated layout gravity, color, line spacing in the XML file.
   The rest of the layout depends on the tab size, and is thus generated
   programatically in onMeasure().

After these changes, the narrow (width <= 720dp) versions of the NTP
match the spec:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI/files/MCGdLy...

This CL does NOT yet contain the wide screen layout (width > 720dp)
which places the two sets of bulletpoints next to each other.

BUG=693525
==========

to

==========
Make the narrow version of the Android Incognito NTP follow the spec

This CL contains improvements of the new Incognito NTP on Android.

1. Bulletpoints: Added the bulletpoint symbol (U+2022), stripped extra
   leading and trailing whitespace.

2. Layout: Updated layout gravity, color, line spacing in the XML file.
   The rest of the layout depends on the tab size, and is thus generated
   programatically in onMeasure().

After these changes, the narrow (width <= 720dp) versions of the NTP
match the spec:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI/files/MCGdLy...

This CL does NOT yet contain the wide screen layout (width > 720dp)
which places the two sets of bulletpoints next to each other.

BUG=693525

Review-Url: https://codereview.chromium.org/2933903002
Cr-Commit-Position: refs/heads/master@{#478989}
Committed:
https://chromium.googlesource.com/chromium/src/+/42b293e0d826de47c6ecd71774a4...
==========

[commit-bot: I haz the power, 2017-06-13 12:58:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/42b293e0d826de47c6ecd71774a4...