Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2933893002: Add services_unittests to the release Android tests too. (Closed)

Created:
3 years, 6 months ago by Elliot Glaysher
Modified:
3 years, 6 months ago
Reviewers:
Nico, jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add services_unittests to the release Android tests too. BUG=732060 Review-Url: https://codereview.chromium.org/2933893002 Cr-Commit-Position: refs/heads/master@{#478806} Committed: https://chromium.googlesource.com/chromium/src/+/12a593b1a82b23a4b7a814ef88d6dcad9bb7844d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Magic invocation from jbudorick #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M testing/buildbot/chromium.linux.json View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Elliot Glaysher
This adds services_unittests to linux_android_rel_ng. https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/315576
3 years, 6 months ago (2017-06-12 19:04:03 UTC) #5
Nico
vaguely lgtm, but I don't know the Android swarming test setup well. jbudorick does, maybe ...
3 years, 6 months ago (2017-06-12 19:41:44 UTC) #7
jbudorick
lgtm w/ nit https://codereview.chromium.org/2933893002/diff/1/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/2933893002/diff/1/testing/buildbot/chromium.linux.json#newcode1236 testing/buildbot/chromium.linux.json:1236: { Can you add the following ...
3 years, 6 months ago (2017-06-12 19:47:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933893002/20001
3 years, 6 months ago (2017-06-12 21:29:03 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 23:04:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12a593b1a82b23a4b7a814ef88d6...

Powered by Google App Engine
This is Rietveld 408576698