|
|
Chromium Code Reviews|
Created:
3 years, 6 months ago by Elliot Glaysher Modified:
3 years, 6 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd services_unittests to the release Android tests too.
BUG=732060
Review-Url: https://codereview.chromium.org/2933893002
Cr-Commit-Position: refs/heads/master@{#478806}
Committed: https://chromium.googlesource.com/chromium/src/+/12a593b1a82b23a4b7a814ef88d6dcad9bb7844d
Patch Set 1 #
Total comments: 1
Patch Set 2 : Magic invocation from jbudorick #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by erg@chromium.org
erg@chromium.org changed reviewers: + thakis@chromium.org
This adds services_unittests to linux_android_rel_ng. https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
thakis@chromium.org changed reviewers: + jbudorick@chromium.org
vaguely lgtm, but I don't know the Android swarming test setup well. jbudorick does, maybe he wants to take a look too.
lgtm w/ nit https://codereview.chromium.org/2933893002/diff/1/testing/buildbot/chromium.l... File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/2933893002/diff/1/testing/buildbot/chromium.l... testing/buildbot/chromium.linux.json:1236: { Can you add the following here: "merge": { "args": [ "--bucket", "chromium-result-details", "--test-name", "services_unittests" ], "script": "//build/android/pylib/results/presentation/test_results_presentation.py" }, I'm landing the equivalent for Android Tests (dbg) over in https://chromium-review.googlesource.com/c/531793/
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org, jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2933893002/#ps20001 (title: "Magic invocation from jbudorick")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497302910340630,
"parent_rev": "e7fe96812663e16778c2517bd3587eded541088e", "commit_rev":
"12a593b1a82b23a4b7a814ef88d6dcad9bb7844d"}
Message was sent while issue was closed.
Description was changed from ========== Add services_unittests to the release Android tests too. BUG=732060 ========== to ========== Add services_unittests to the release Android tests too. BUG=732060 Review-Url: https://codereview.chromium.org/2933893002 Cr-Commit-Position: refs/heads/master@{#478806} Committed: https://chromium.googlesource.com/chromium/src/+/12a593b1a82b23a4b7a814ef88d6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/12a593b1a82b23a4b7a814ef88d6... |
