Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2933853003: Streams: Fix exception message for NaN HWM (Closed)

Created:
3 years, 6 months ago by Adam Rice
Modified:
3 years, 6 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Streams: Fix exception message for NaN HWM ReadableStream and WritableStream both used streamErrors.errInvalidHWM instead of streamErrors.invalidHWM for the message when a strategy highWaterMark was NaN. This resulted in a RangeError being thrown with an empty message. Because the web platform tests don't look at the message, they didn't catch the bug. Fix the message. Also add a Chromium-specific regression test to validate that it is correct. BUG=719763 Review-Url: https://codereview.chromium.org/2933853003 Cr-Commit-Position: refs/heads/master@{#478880} Committed: https://chromium.googlesource.com/chromium/src/+/7f4a499745ae9a8601e20ef616e8e1e877934269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/streams/chromium/err-invalid-hwm.html View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStream.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/WritableStream.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Adam Rice
3 years, 6 months ago (2017-06-13 00:43:10 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm
3 years, 6 months ago (2017-06-13 01:06:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933853003/1
3 years, 6 months ago (2017-06-13 01:31:01 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 03:15:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f4a499745ae9a8601e20ef616e8...

Powered by Google App Engine
This is Rietveld 408576698