Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 293383004: Require at least a 25 degree rise angle before changing screen rotation. (Closed)

Created:
6 years, 7 months ago by flackr
Modified:
6 years, 7 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Require at least a 25 degree rise angle before changing screen rotation. BUG=377508 TEST=Manually verified this updated angle matches expectations. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272897

Patch Set 1 #

Patch Set 2 : Expand on comment to mention sine of angle. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ash/wm/maximize_mode/maximize_mode_controller.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
flackr
PTAL, thanks.
6 years, 7 months ago (2014-05-26 18:11:06 UTC) #1
varkha
nit: maybe document the fact that the constant is a sin(angle). lgtm, thanks!
6 years, 7 months ago (2014-05-26 18:16:35 UTC) #2
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 7 months ago (2014-05-26 18:21:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/293383004/20001
6 years, 7 months ago (2014-05-26 18:22:11 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 00:11:44 UTC) #5
Message was sent while issue was closed.
Change committed as 272897

Powered by Google App Engine
This is Rietveld 408576698