Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3066)

Unified Diff: ash/wm/maximize_mode/maximize_mode_controller.cc

Issue 293383004: Require at least a 25 degree rise angle before changing screen rotation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Expand on comment to mention sine of angle. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/maximize_mode/maximize_mode_controller.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_controller.cc b/ash/wm/maximize_mode/maximize_mode_controller.cc
index a969a91a07eca81e03746771c5cca4be2365de9f..2ca5e6261b282228d15010a9f9aef1ac2357e0fd 100644
--- a/ash/wm/maximize_mode/maximize_mode_controller.cc
+++ b/ash/wm/maximize_mode/maximize_mode_controller.cc
@@ -60,8 +60,10 @@ const float kDisplayRotationStickyAngleDegrees = 60.0f;
// The minimum acceleration in a direction required to trigger screen rotation.
// This prevents rapid toggling of rotation when the device is near flat and
-// there is very little screen aligned force on it.
-const float kMinimumAccelerationScreenRotation = 0.3f;
+// there is very little screen aligned force on it. The value is effectively the
+// sine of the rise angle required, with the current value requiring at least a
+// 25 degree rise.
+const float kMinimumAccelerationScreenRotation = 0.42f;
const float kRadiansToDegrees = 180.0f / 3.14159265f;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698