[ObjC ARC] Converts ios/chrome/app:app_internal to ARC.

[ObjC ARC] Converts ios/chrome/app:app_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933823002
Cr-Commit-Position: refs/heads/master@{#478736}
Committed: https://chromium.googlesource.com/chromium/src/+/ede0aba2993bf0ef7a9bf05a0ed6c5c62ad7460e

[marq (ping after 24h), 2017-06-12 11:39:40]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 11:39:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-12 12:22:11]

marq@chromium.org changed reviewers:
+ gambard@chromium.org, stkhapugin@chromium.org

[gambard, 2017-06-12 12:42:48]

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:251: MainCoordinator* _mainCoordinator;
Can probably be synthesize instead.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:273: int _foregroundMemoryWarningCount;
Is this used?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:277: CFAbsoluteTime _outOfMemoryResetTime;
Is it used?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:872: - (NSDictionary*)launchOptions {
Synthesize?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:886: -
(AppStartupParameters*)startupParameters {
Remove this getter and the setter below for a synthesize?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:914: - (MetricsMediator*)metricsMediator {
Same, synthesize here and below instead?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:922: -
(SettingsNavigationController*)settingsNavigationController {
Same

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:1430: } break;
Is this cl format? Why is break outside of the brackets?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2559: -
(UIViewController<TabSwitcher>*)tabSwitcherController {
Synthesize?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2567: -
(SigninInteractionController*)signinInteractionController {
Synthesize?

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2576: -
(void)setTabSwitcherActive:(BOOL)active {
Synthesize

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2580: - (BOOL)dismissingTabSwitcher {
Synthesize

[commit-bot: I haz the power, 2017-06-12 12:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 12:58:33]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-06-12 14:25:10]

Thanks, PTAL.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:251: MainCoordinator* _mainCoordinator;
On 2017/06/12 12:42:47, gambard wrote:
> Can probably be synthesize instead.

The lazy init behavior, coupled with a few places where there are DCHECKs that
the init hasn't happened, make this hard.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:273: int _foregroundMemoryWarningCount;
On 2017/06/12 12:42:48, gambard wrote:
> Is this used?

No, but I'll remove it in another CL.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:277: CFAbsoluteTime _outOfMemoryResetTime;
On 2017/06/12 12:42:48, gambard wrote:
> Is it used?

No, but I'll remove it in another CL.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:872: - (NSDictionary*)launchOptions {
On 2017/06/12 12:42:48, gambard wrote:
> Synthesize?

Done.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:886: -
(AppStartupParameters*)startupParameters {
On 2017/06/12 12:42:48, gambard wrote:
> Remove this getter and the setter below for a synthesize?

Done.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:914: - (MetricsMediator*)metricsMediator {
On 2017/06/12 12:42:47, gambard wrote:
> Same, synthesize here and below instead?

Done.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:922: -
(SettingsNavigationController*)settingsNavigationController {
On 2017/06/12 12:42:48, gambard wrote:
> Same

Done.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2559: -
(UIViewController<TabSwitcher>*)tabSwitcherController {
On 2017/06/12 12:42:48, gambard wrote:
> Synthesize?

These properties are only declared in the TestingOnly category, so they can't be
synthesized.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2567: -
(SigninInteractionController*)signinInteractionController {
On 2017/06/12 12:42:48, gambard wrote:
> Synthesize?

See above.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2576: -
(void)setTabSwitcherActive:(BOOL)active {
On 2017/06/12 12:42:48, gambard wrote:
> Synthesize

Not for this CL, and also see above.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2580: - (BOOL)dismissingTabSwitcher {
On 2017/06/12 12:42:48, gambard wrote:
> Synthesize

Not for this CL, and also see above.

[marq (ping after 24h), 2017-06-12 14:25:53]

Review Feedback.

[gambard, 2017-06-12 14:44:54]

lgtm with one comment.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:251: MainCoordinator* _mainCoordinator;
On 2017/06/12 14:25:09, marq (ping after 24h) wrote:
> On 2017/06/12 12:42:47, gambard wrote:
> > Can probably be synthesize instead.
> 
> The lazy init behavior, coupled with a few places where there are DCHECKs that
> the init hasn't happened, make this hard.

Sorry my comment was unclear. The ivar declaration can be done in a synthesize.
The getter should stay the same.
Unless there is a difference I am not aware of between ivar and synthesize.

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:2559: -
(UIViewController<TabSwitcher>*)tabSwitcherController {
On 2017/06/12 14:25:09, marq (ping after 24h) wrote:
> On 2017/06/12 12:42:48, gambard wrote:
> > Synthesize?
> 
> These properties are only declared in the TestingOnly category, so they can't
be
> synthesized.

Acknowledged.

[marq (ping after 24h), 2017-06-12 16:24:45]

Synthesis!

[marq (ping after 24h), 2017-06-12 16:24:46]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-12 16:24:46]

The patchset sent to the CQ was uploaded after l-g-t-m from gambard@chromium.org
Link to the patchset: https://codereview.chromium.org/2933823002/#ps40001
(title: "Synthesis!")

[commit-bot: I haz the power, 2017-06-12 16:25:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-12 16:25:29]

Thanks for the review!

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2933823002/diff/1/ios/chrome/app/main_control...
ios/chrome/app/main_controller.mm:251: MainCoordinator* _mainCoordinator;
On 2017/06/12 14:44:54, gambard wrote:
> On 2017/06/12 14:25:09, marq (ping after 24h) wrote:
> > On 2017/06/12 12:42:47, gambard wrote:
> > > Can probably be synthesize instead.
> > 
> > The lazy init behavior, coupled with a few places where there are DCHECKs
that
> > the init hasn't happened, make this hard.
> 
> Sorry my comment was unclear. The ivar declaration can be done in a
synthesize.
> The getter should stay the same.
> Unless there is a difference I am not aware of between ivar and synthesize.

Gotcha. Done.

[commit-bot: I haz the power, 2017-06-12 16:27:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 16:27:53]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[marq (ping after 24h), 2017-06-12 18:15:46]

Rebased

[marq (ping after 24h), 2017-06-12 18:15:47]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-12 18:15:47]

The patchset sent to the CQ was uploaded after l-g-t-m from gambard@chromium.org
Link to the patchset: https://codereview.chromium.org/2933823002/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2017-06-12 18:16:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:11:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497291347180630,
"parent_rev": "41d32a3c1bd0153aa660378b3b2a2c59e25c5f31", "commit_rev":
"ede0aba2993bf0ef7a9bf05a0ed6c5c62ad7460e"}

[commit-bot: I haz the power, 2017-06-12 20:11:27]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/app:app_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/app:app_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933823002
Cr-Commit-Position: refs/heads/master@{#478736}
Committed:
https://chromium.googlesource.com/chromium/src/+/ede0aba2993bf0ef7a9bf05a0ed6...
==========

[commit-bot: I haz the power, 2017-06-12 20:11:30]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ede0aba2993bf0ef7a9bf05a0ed6...