Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2933803002: PlzNavigate: checking post_id() in test PostInSubframe. (Closed)

Created:
3 years, 6 months ago by arthursonzogni
Modified:
3 years, 6 months ago
Reviewers:
clamy
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, nasko
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: checking post_id() in test PostInSubframe. Remove the TODO and enable the disabled test expectation. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2933803002 Cr-Commit-Position: refs/heads/master@{#478625} Committed: https://chromium.googlesource.com/chromium/src/+/a991dac91a999d658b2d76d89c74038fced3fa8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
arthursonzogni
Hi Camille, Could you please review this?
3 years, 6 months ago (2017-06-12 10:05:46 UTC) #8
clamy
Thanks! Lgtm.
3 years, 6 months ago (2017-06-12 15:09:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933803002/1
3 years, 6 months ago (2017-06-12 15:11:49 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 15:16:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a991dac91a999d658b2d76d89c74...

Powered by Google App Engine
This is Rietveld 408576698