When a stream is created for a QUIC session to a server which has been

When a stream is created for a QUIC session to a server which has been
marked as broken, mark the session as going away.

BUG=731303
Review-Url: https://codereview.chromium.org/2933773002
Cr-Commit-Position: refs/heads/master@{#478771}
Committed: https://chromium.googlesource.com/chromium/src/+/30943ee5e8e8b775a6870c8ef2fa0a92d56df1d9

[Ryan Hamilton, 2017-06-11 22:06:09]

rch@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Ryan Hamilton, 2017-06-12 18:44:09]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 18:44:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 19:27:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 19:27:26]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Zhongyi Shi, 2017-06-12 19:27:47]

Looks great!

Great to have those complicated unittests. Just a couple of nits.

https://codereview.chromium.org/2933773002/diff/20001/net/quic/chromium/quic_...
File net/quic/chromium/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2933773002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_network_transaction_unittest.cc:2692: // because the
request can be pooled to that one.
Reading the comments, I was expecting there are two alternative services entries
be set for origin2. However, I only saw one on line 2695. Is the comment out of
date?

https://codereview.chromium.org/2933773002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_network_transaction_unittest.cc:2716: // retried over
TCP.
nit: the description of the two tests are identical, could you say a little bit
more about the difference in the description?

[Ryan Hamilton, 2017-06-12 19:43:08]

Thanks.

https://codereview.chromium.org/2933773002/diff/20001/net/quic/chromium/quic_...
File net/quic/chromium/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2933773002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_network_transaction_unittest.cc:2692: // because the
request can be pooled to that one.
On 2017/06/12 19:27:47, Zhongyi Shi wrote:
> Reading the comments, I was expecting there are two alternative services
entries
> be set for origin2. However, I only saw one on line 2695. Is the comment out
of
> date?

Yup. Out of date. Fixed.

https://codereview.chromium.org/2933773002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_network_transaction_unittest.cc:2716: // retried over
TCP.
On 2017/06/12 19:27:47, Zhongyi Shi wrote:
> nit: the description of the two tests are identical, could you say a little
bit
> more about the difference in the description?

Whoops, sorry about that. I wrote this first and thought it was the only test I
needed, but eventually realized I needed a second so I made a copy and started
hacking it up. But then I forgot all about it!

Update the comment, and re-ordered the tests to put the simpler test first.

[Ryan Hamilton, 2017-06-12 19:43:26]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 19:43:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-06-12 19:47:00]

lgtm!

[Ryan Hamilton, 2017-06-12 21:06:49]

The CQ bit was unchecked by rch@chromium.org

[Ryan Hamilton, 2017-06-12 21:06:52]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:07:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 21:28:47]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1497301612412680,
"parent_rev": "72b0661cd1fbc0297200f9ca88be19bdeb865508", "commit_rev":
"30943ee5e8e8b775a6870c8ef2fa0a92d56df1d9"}

[commit-bot: I haz the power, 2017-06-12 21:28:59]

Description was changed from

==========
When a stream is created for a QUIC session to a server which has been
marked as broken, mark the session as going away.

BUG=731303
==========

to

==========
When a stream is created for a QUIC session to a server which has been
marked as broken, mark the session as going away.

BUG=731303

Review-Url: https://codereview.chromium.org/2933773002
Cr-Commit-Position: refs/heads/master@{#478771}
Committed:
https://chromium.googlesource.com/chromium/src/+/30943ee5e8e8b775a6870c8ef2fa...
==========

[commit-bot: I haz the power, 2017-06-12 21:29:00]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/30943ee5e8e8b775a6870c8ef2fa...