Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2933753002: Run the sorter to reduce code churn (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1679 lines, -1680 lines) Patch
M pkg/analysis_server/lib/src/collections.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +24 lines, -24 lines 0 comments Download
M pkg/analysis_server/lib/src/status/diagnostics.dart View 9 chunks +732 lines, -732 lines 0 comments Download
M pkg/analysis_server/lib/src/status/pages.dart View 5 chunks +107 lines, -107 lines 0 comments Download
M pkg/analyzer/lib/instrumentation/file_instrumentation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/command_line/arguments.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 4 chunks +60 lines, -60 lines 0 comments Download
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/gn.dart View 3 chunks +65 lines, -65 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/workspace.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/lint/registry.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/ast_properties.dart View 3 chunks +22 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +24 lines, -24 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 3 chunks +31 lines, -31 lines 0 comments Download
M pkg/analyzer/test/generated/gn_test.dart View 1 chunk +16 lines, -16 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +17 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 7 chunks +31 lines, -31 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +17 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 3 chunks +34 lines, -34 lines 0 comments Download
M pkg/analyzer/test/src/summary/package_bundle_reader_test.dart View 4 chunks +32 lines, -32 lines 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 5 chunks +48 lines, -48 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/tool/summary/mini_ast.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 6 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer_cli/lib/src/ansi.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/analyzer_cli/lib/src/error_formatter.dart View 6 chunks +178 lines, -178 lines 0 comments Download
M pkg/analyzer_cli/lib/src/error_severity.dart View 2 chunks +22 lines, -22 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/test/utils.dart View 2 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer_cli/tool/perf.dart View 5 chunks +90 lines, -90 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
These are exclusively changes made by Sort Members in Dart File. I didn't sort the ...
3 years, 6 months ago (2017-06-11 17:59:26 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-11 20:11:17 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-12 14:37:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
62d03762318ab3fade525938af20ec557072266d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698