Run the sorter to reduce code churn

pkg/analyzer_cli/lib/src/analyzer_impl.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.src.analyzer_impl;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:io';
 
@@ skipping 46 matching lines @@
   /// If the file specified on the command line is part of a package, the name
   /// of that package.  Otherwise `null`.  This allows us to analyze the file
   /// specified on the command line as though it is reached via a "package:"
   /// URI, but avoid suppressing its output in the event that the user has not
   /// specified the "--package-warnings" option.
   String _selfPackageName;
 
   AnalyzerImpl(this.analysisOptions, this.context, this.analysisDriver,
       this.librarySource, this.options, this.stats, this.startTime);
 
-  /// Returns the maximal [ErrorSeverity] of the recorded errors.
-  ErrorSeverity computeMaxErrorSeverity() {
-    ErrorSeverity status = ErrorSeverity.NONE;
-    for (AnalysisErrorInfo errorInfo in errorInfos) {
-      for (AnalysisError error in errorInfo.errors) {
-        if (_defaultSeverityProcessor(error) == null) {
-          continue;
-        }
-        status = status.max(computeSeverity(error, options, analysisOptions));
-      }
-    }
-    return status;
-  }
-
   void addCompilationUnitSource(
       CompilationUnitElement unit, Set<CompilationUnitElement> units) {
     if (unit == null || !units.add(unit)) {
       return;
     }
     Source source = unit.source;
     if (source != null) {
       sources.add(source);
     }
   }
@@ skipping 25 matching lines @@
   /// the analysis engine. If [printMode] is `0`, then no error or performance
   /// information is printed. If [printMode] is `1`, then errors will be printed.
   /// If [printMode] is `2`, then performance information will be printed, and
   /// it will be marked as being for a cold VM.
   Future<ErrorSeverity> analyze(ErrorFormatter formatter,
       {int printMode: 1}) async {
     setupForAnalysis();
     return await _analyze(printMode, formatter);
   }
 
+  /// Returns the maximal [ErrorSeverity] of the recorded errors.
+  ErrorSeverity computeMaxErrorSeverity() {
+    ErrorSeverity status = ErrorSeverity.NONE;
+    for (AnalysisErrorInfo errorInfo in errorInfos) {
+      for (AnalysisError error in errorInfo.errors) {
+        if (_defaultSeverityProcessor(error) == null) {
+          continue;
+        }
+        status = status.max(computeSeverity(error, options, analysisOptions));
+      }
+    }
+    return status;
+  }
+
   /// Fills [errorInfos] using [sources].
   Future<Null> prepareErrors() async {
     PerformanceTag previous = _prepareErrorsTag.makeCurrent();
     try {
       for (Source source in sources) {
         if (analysisDriver != null) {
           String path = source.fullName;
           ErrorsResult errorsResult = await analysisDriver.getErrors(path);
           errorInfos.add(new AnalysisErrorInfoImpl(
               errorsResult.errors, errorsResult.lineInfo));
@@ skipping 45 matching lines @@
     if (printMode == 1) {
       formatter.formatErrors(errorInfos);
     } else if (printMode == 2) {
       _printColdPerf();
     }
 
     // Compute and return max severity.
     return computeMaxErrorSeverity();
   }
 
+  ErrorSeverity _defaultSeverityProcessor(AnalysisError error) =>
+      determineProcessedSeverity(error, options, analysisOptions);
+
   /// Returns true if we want to report diagnostics for this library.
   bool _isAnalyzedLibrary(LibraryElement library) {
     Source source = library.source;
     switch (source.uriKind) {
       case UriKind.DART_URI:
         return options.showSdkWarnings;
       case UriKind.PACKAGE_URI:
         if (_isPathInPubCache(source.fullName)) {
           return false;
         }
         return _isAnalyzedPackage(source.uri);
       default:
         return true;
     }
   }
 
+  // TODO(devoncarew): This is never called.
   /// Determine whether the given URI refers to a package being analyzed.
   bool _isAnalyzedPackage(Uri uri) {
     if (uri.scheme != 'package' || uri.pathSegments.isEmpty) {
       return false;
     }
     String packageName = uri.pathSegments.first;
     if (packageName == _selfPackageName) {
       return true;
     } else if (!options.showPackageWarnings) {
       return false;
     } else if (options.showPackageWarningsPrefix == null) {
       return true;
     } else {
       return packageName.startsWith(options.showPackageWarningsPrefix);
     }
   }
 
-  // TODO(devoncarew): This is never called.
   void _printColdPerf() {
     // Print cold VM performance numbers.
     int totalTime = currentTimeMillis - startTime;
     int otherTime = totalTime;
     for (PerformanceTag tag in PerformanceTag.all) {
       if (tag != PerformanceTag.unknown) {
         int tagTime = tag.elapsedMs;
         outSink.writeln('${tag.label}-cold:$tagTime');
         otherTime -= tagTime;
       }
     }
     outSink.writeln('other-cold:$otherTime');
     outSink.writeln("total-cold:$totalTime");
   }
 
-  ErrorSeverity _defaultSeverityProcessor(AnalysisError error) =>
-      determineProcessedSeverity(error, options, analysisOptions);
-
   Future<LibraryElement> _resolveLibrary() async {
     PerformanceTag previous = _resolveLibraryTag.makeCurrent();
     try {
       if (analysisDriver != null) {
         String path = librarySource.fullName;
         analysisDriver.priorityFiles = [path];
         UnitElementResult elementResult =
             await analysisDriver.getUnitElement(path);
         return elementResult.element.library;
       } else {
@@ skipping 50 matching lines @@
   }
 
   @override
   void logInformation(String message, [CaughtException exception]) {
     outSink.writeln(message);
     if (exception != null) {
       outSink.writeln(exception);
     }
   }
 }