Complain about duplicated defer.

Complain about duplicated defer.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/0c7d657333a1aa5660740c33b4beccbc0fd52c1a

[ahe, 2017-06-11 11:23:38]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, paulberry@google.com

[Johnni Winther, 2017-06-12 08:09:13]

lgtm

https://codereview.chromium.org/2933723002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2933723002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:285: "Can't use
the name '$name' for a deferred library, as the name is used elsewhere.");
Long line + below

https://codereview.chromium.org/2933723002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:288: if
(existing.deferred) {
Make this an `else if` to avoid to errors when both are deferred. Or maybe
special case that situation?

[ahe, 2017-06-12 08:33:28]

Thank you, Johnni! I'll address these points in a follow-up CL.

https://codereview.chromium.org/2933723002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_library_builder.dart (right):

https://codereview.chromium.org/2933723002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:285: "Can't use
the name '$name' for a deferred library, as the name is used elsewhere.");
On 2017/06/12 08:09:13, Johnni Winther wrote:
> Long line + below

Acknowledged.

https://codereview.chromium.org/2933723002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:288: if
(existing.deferred) {
On 2017/06/12 08:09:13, Johnni Winther wrote:
> Make this an `else if` to avoid to errors when both are deferred. Or maybe
> special case that situation?

Acknowledged.

[ahe, 2017-06-12 08:33:45]

Description was changed from

==========
Complain about duplicated defer.
==========

to

==========
Complain about duplicated defer.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0c7d657333a1aa5660740c33b4beccbc0fd52c1a
==========

[ahe, 2017-06-12 08:33:46]

Committed patchset #1 (id:1) manually as
0c7d657333a1aa5660740c33b4beccbc0fd52c1a (presubmit successful).