Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2932973003: Various semantic checks regarding const and final. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +37 lines, -1 line 2 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 4 chunks +0 lines, -14 lines 0 comments Download
M tests/language/language_kernel.status View 3 chunks +0 lines, -14 lines 0 comments Download

Dependent Patchsets:

Issue 2933723002 Patch 1

Messages

Total messages: 7 (3 generated)
ahe
3 years, 6 months ago (2017-06-11 11:21:43 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2932973003/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2932973003/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode2016 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2016: Procedure factory = target; Shouldn't this be in ...
3 years, 6 months ago (2017-06-12 07:46:17 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/2932973003/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2932973003/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode2016 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2016: Procedure factory = target; On 2017/06/12 ...
3 years, 6 months ago (2017-06-12 08:13:22 UTC) #5
ahe
3 years, 6 months ago (2017-06-12 08:27:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
35d77460e4cdbb6609565cdc66a554b9b8473902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698