Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2933693002: Add Null checks in VideoCaptureCamera2.java (Closed)

Created:
3 years, 6 months ago by horo
Modified:
3 years, 6 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, agrieve+watch_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Null checks in VideoCaptureCamera2.java BUG=728735 Review-Url: https://codereview.chromium.org/2933693002 Cr-Commit-Position: refs/heads/master@{#478515} Committed: https://chromium.googlesource.com/chromium/src/+/6dcccd8c3f381d7127a3a3d83cf647daae594c97

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 2 chunks +7 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (9 generated)
horo
mcasas@chromium.org Could you please review?
3 years, 6 months ago (2017-06-10 06:58:33 UTC) #5
mcasas
lgtm lgtm, thanks! https://codereview.chromium.org/2933693002/diff/1/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/2933693002/diff/1/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java#newcode768 media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:768: if (mPreviewRequestBuilder.get(CaptureRequest.SENSOR_SENSITIVITY) != null) { micro-nit: ...
3 years, 6 months ago (2017-06-10 14:47:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933693002/1
3 years, 6 months ago (2017-06-10 14:47:29 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-10 14:51:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6dcccd8c3f381d7127a3a3d83cf6...

Powered by Google App Engine
This is Rietveld 408576698