Preparing to making answer-card independent of fullscreen.

Preparing to making answer-card independent of fullscreen.

We decided that it is possible to have answer cards in Launcher even
before full-screen launcher is implemented.

As answer cards dictate the design of the whole search result page, new
search result page design will be applied when answer-card flag is on,
even without the full-screen flag.

The full-screen launcher comes with a total redesign of everything,
including search results page, so the new design for search results page
will be applied if full-screen flag is on, even without answer-card
flag.

This means that old design of search results page will be preserved only
when both flags are off.

Also, removing some unnecessary code.

Bug=712331
Review-Url: https://codereview.chromium.org/2933673002
Cr-Commit-Position: refs/heads/master@{#478700}
Committed: https://chromium.googlesource.com/chromium/src/+/2a35c6ab11910b5dd1cd63c5ac10b727f03492b3

[vadimt, 2017-06-10 02:04:29]

vadimt@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2017-06-12 16:16:13]

lgtm

https://codereview.chromium.org/2933673002/diff/1/ui/app_list/views/app_list_...
File ui/app_list/views/app_list_main_view.cc (right):

https://codereview.chromium.org/2933673002/diff/1/ui/app_list/views/app_list_...
ui/app_list/views/app_list_main_view.cc:54:
SetLayoutManager(static_cast<views::LayoutManager*>(
Is static_cast still necessary?

[vadimt, 2017-06-12 18:13:11]

https://codereview.chromium.org/2933673002/diff/1/ui/app_list/views/app_list_...
File ui/app_list/views/app_list_main_view.cc (right):

https://codereview.chromium.org/2933673002/diff/1/ui/app_list/views/app_list_...
ui/app_list/views/app_list_main_view.cc:54:
SetLayoutManager(static_cast<views::LayoutManager*>(
On 2017/06/12 16:16:13, xiyuan wrote:
> Is static_cast still necessary?

Done.

[vadimt, 2017-06-12 18:13:19]

The CQ bit was checked by vadimt@chromium.org

[vadimt, 2017-06-12 18:13:20]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2933673002/#ps20001
(title: "CR comments")

[commit-bot: I haz the power, 2017-06-12 18:13:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:51:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497291199865920,
"parent_rev": "c801f245e80080ae7e3ca6323ac43f8f793c32e1", "commit_rev":
"2a35c6ab11910b5dd1cd63c5ac10b727f03492b3"}

[commit-bot: I haz the power, 2017-06-12 18:51:34]

Description was changed from

==========
Preparing to making answer-card independent of fullscreen.

We decided that it is possible to have answer cards in Launcher even
before full-screen launcher is implemented.

As answer cards dictate the design of the whole search result page, new
search result page design will be applied when answer-card flag is on,
even without the full-screen flag.

The full-screen launcher comes with a total redesign of everything,
including search results page, so the new design for search results page
will be applied if full-screen flag is on, even without answer-card
flag.

This means that old design of search results page will be preserved only
when both flags are off.

Also, removing some unnecessary code.

Bug=712331
==========

to

==========
Preparing to making answer-card independent of fullscreen.

We decided that it is possible to have answer cards in Launcher even
before full-screen launcher is implemented.

As answer cards dictate the design of the whole search result page, new
search result page design will be applied when answer-card flag is on,
even without the full-screen flag.

The full-screen launcher comes with a total redesign of everything,
including search results page, so the new design for search results page
will be applied if full-screen flag is on, even without answer-card
flag.

This means that old design of search results page will be preserved only
when both flags are off.

Also, removing some unnecessary code.

Bug=712331

Review-Url: https://codereview.chromium.org/2933673002
Cr-Commit-Position: refs/heads/master@{#478700}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a35c6ab11910b5dd1cd63c5ac10...
==========

[commit-bot: I haz the power, 2017-06-12 18:51:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a35c6ab11910b5dd1cd63c5ac10...

[stevenjb, 2017-07-11 22:34:24]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-07-11 22:34:24]

https://codereview.chromium.org/2933673002/diff/20001/ui/app_list/app_list_fe...
File ui/app_list/app_list_features.h (right):

https://codereview.chromium.org/2933673002/diff/20001/ui/app_list/app_list_fe...
ui/app_list/app_list_features.h:34: bool APP_LIST_EXPORT
IsSearchResultsNewDesignEnabled();
This is an unfortunate name for a feature. The "New Design" quickly becomes the
"Old Design". Can we come up with a better name for the feature and change the
code before this propagates?

[vadimt, 2017-07-11 23:04:41]

https://codereview.chromium.org/2933673002/diff/20001/ui/app_list/app_list_fe...
File ui/app_list/app_list_features.h (right):

https://codereview.chromium.org/2933673002/diff/20001/ui/app_list/app_list_fe...
ui/app_list/app_list_features.h:34: bool APP_LIST_EXPORT
IsSearchResultsNewDesignEnabled();
I'll rename it into "TouchFriendlySearchResults" in my next CL. Thanks!