Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2933653002: Remove bidi checker tests and some of the backing code (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 5 months ago
Reviewers:
agrieve, dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove bidi checker tests and some of the backing code R=agrieve@chromium.org BUG=511439, 728353, 94642 Review-Url: https://codereview.chromium.org/2933653002 Cr-Commit-Position: refs/heads/master@{#489361} Committed: https://chromium.googlesource.com/chromium/src/+/aeb9d32b6c3329f1ee586f48294e625a19a3c31c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -801 lines) Patch
D chrome/browser/ui/webui/bidi_checker_web_ui_test.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 chunk +0 lines, -726 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Dan Beam
thoughts?
3 years, 6 months ago (2017-06-10 01:12:22 UTC) #6
agrieve
On 2017/06/10 01:12:22, Dan Beam wrote: > thoughts? I've never worked with bidi on Chrome. ...
3 years, 6 months ago (2017-06-12 14:36:59 UTC) #7
dpapad
LGTM
3 years, 5 months ago (2017-07-25 01:00:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933653002/1
3 years, 5 months ago (2017-07-25 17:46:11 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 17:52:25 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aeb9d32b6c3329f1ee586f48294e...

Powered by Google App Engine
This is Rietveld 408576698