Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 293363010: [chromedriver] Fix some minor errors. (Closed)

Created:
6 years, 6 months ago by stgao
Modified:
6 years, 6 months ago
Reviewers:
samuong
CC:
chromium-reviews, stgao
Visibility:
Public.

Description

[chromedriver] Fix some minor errors. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M chrome/test/chromedriver/chrome/heap_snapshot_taker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/heap_snapshot_taker.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
stgao
ptal
6 years, 6 months ago (2014-05-27 18:06:14 UTC) #1
samuong
On 2014/05/27 18:06:14, Shuotao wrote: > ptal lgtm
6 years, 6 months ago (2014-05-27 19:49:01 UTC) #2
stgao
The CQ bit was checked by stgao@chromium.org
6 years, 6 months ago (2014-05-27 19:49:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stgao@chromium.org/293363010/1
6 years, 6 months ago (2014-05-27 19:50:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-27 19:50:24 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-27 19:50:24 UTC) #6
stgao
The CQ bit was checked by stgao@chromium.org
6 years, 6 months ago (2014-05-28 04:56:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stgao@chromium.org/293363010/1
6 years, 6 months ago (2014-05-28 04:57:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 04:57:09 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-28 04:57:09 UTC) #10
stgao
The CQ bit was checked by stgao@chromium.org
6 years, 6 months ago (2014-05-29 00:05:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stgao@chromium.org/293363010/1
6 years, 6 months ago (2014-05-29 00:07:00 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 00:07:03 UTC) #13
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-29 00:07:03 UTC) #14
stgao
The CQ bit was checked by stgao@chromium.org
6 years, 6 months ago (2014-06-04 00:34:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stgao@chromium.org/293363010/1
6 years, 6 months ago (2014-06-04 00:35:17 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 04:13:34 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 08:40:04 UTC) #18
Message was sent while issue was closed. 
Change committed as 274729

Powered by Google App Engine
This is Rietveld 408576698