Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: chrome/test/chromedriver/chrome/heap_snapshot_taker.cc

Issue 293363010: [chromedriver] Fix some minor errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/heap_snapshot_taker.cc
diff --git a/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc b/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc
index 51c1247b781bffb938f1250b071337abeaa9cb8e..996d78d09508973cac8d92202428f733ba58fc07 100644
--- a/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc
+++ b/chrome/test/chromedriver/chrome/heap_snapshot_taker.cc
@@ -25,18 +25,20 @@ Status HeapSnapshotTaker::TakeSnapshot(scoped_ptr<base::Value>* snapshot) {
Status status3(kOk);
if (status1.IsOk() && status2.IsOk()) {
scoped_ptr<base::Value> value(base::JSONReader::Read(snapshot_));
- if (!value)
+ if (!value) {
status3 = Status(kUnknownError, "heap snapshot not in JSON format");
- else
+ } else {
*snapshot = value.Pass();
+ }
}
snapshot_.clear();
- if (status1.IsError())
+ if (status1.IsError()) {
return status1;
- else if (status2.IsError())
+ } else if (status2.IsError()) {
return status2;
- else
+ } else {
return status3;
+ }
}
Status HeapSnapshotTaker::TakeSnapshotInternal() {
« no previous file with comments | « chrome/test/chromedriver/chrome/heap_snapshot_taker.h ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698