Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 293363009: First cut at run_mksnapshot action for gn (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
v8-dev
Visibility:
Public.

Description

First cut at run_mksnapshot action for gn BUG=none R=brettw@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21618

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -10 lines) Patch
M BUILD.gn View 1 5 chunks +105 lines, -10 lines 1 comment Download
A tools/run.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
is script = "mksnapshot" enough to make gn build mksnapshot first? And does it figure ...
6 years, 7 months ago (2014-05-27 15:36:59 UTC) #1
brettw
On 2014/05/27 15:36:59, jochen wrote: > is script = "mksnapshot" enough to make gn build ...
6 years, 7 months ago (2014-05-27 17:36:03 UTC) #2
jochen (gone - plz use gerrit)
ptal I also added the v8 target. the only problem is that the resulting binary ...
6 years, 7 months ago (2014-05-27 21:24:55 UTC) #3
brettw
lgtm https://codereview.chromium.org/293363009/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/293363009/diff/20001/BUILD.gn#newcode986 BUILD.gn:986: component("v8") { CAn you indent the stuff inside ...
6 years, 7 months ago (2014-05-27 21:26:23 UTC) #4
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-03 06:50:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698