Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 293363005: LoadUint32() doesn't need a scratch register. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

LoadUint32() doesn't need a scratch register. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21476

Patch Set 1 : #

Patch Set 2 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -54 lines) Patch
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +6 lines, -10 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-05-26 06:28:33 UTC) #1
Jarin
lgtm
6 years, 7 months ago (2014-05-26 06:40:58 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-26 06:41:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698