Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 293363005: LoadUint32() doesn't need a scratch register. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Compile fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/macro-assembler-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "bootstrapper.h" 9 #include "bootstrapper.h"
10 #include "codegen.h" 10 #include "codegen.h"
(...skipping 3305 matching lines...) Expand 10 before | Expand all | Expand 10 after
3316 bind(&conv_failure); 3316 bind(&conv_failure);
3317 Set(result_reg, 0); 3317 Set(result_reg, 0);
3318 ucomisd(input_reg, temp_xmm_reg); 3318 ucomisd(input_reg, temp_xmm_reg);
3319 j(below, &done, Label::kNear); 3319 j(below, &done, Label::kNear);
3320 Set(result_reg, 255); 3320 Set(result_reg, 255);
3321 bind(&done); 3321 bind(&done);
3322 } 3322 }
3323 3323
3324 3324
3325 void MacroAssembler::LoadUint32(XMMRegister dst, 3325 void MacroAssembler::LoadUint32(XMMRegister dst,
3326 Register src, 3326 Register src) {
3327 XMMRegister scratch) {
3328 if (FLAG_debug_code) { 3327 if (FLAG_debug_code) {
3329 cmpq(src, Immediate(0xffffffff)); 3328 cmpq(src, Immediate(0xffffffff));
3330 Assert(below_equal, kInputGPRIsExpectedToHaveUpper32Cleared); 3329 Assert(below_equal, kInputGPRIsExpectedToHaveUpper32Cleared);
3331 } 3330 }
3332 cvtqsi2sd(dst, src); 3331 cvtqsi2sd(dst, src);
3333 } 3332 }
3334 3333
3335 3334
3336 void MacroAssembler::SlowTruncateToI(Register result_reg, 3335 void MacroAssembler::SlowTruncateToI(Register result_reg,
3337 Register input_reg, 3336 Register input_reg,
(...skipping 1897 matching lines...) Expand 10 before | Expand all | Expand 10 after
5235 if (ms.shift() > 0) sarl(rdx, Immediate(ms.shift())); 5234 if (ms.shift() > 0) sarl(rdx, Immediate(ms.shift()));
5236 movl(rax, dividend); 5235 movl(rax, dividend);
5237 shrl(rax, Immediate(31)); 5236 shrl(rax, Immediate(31));
5238 addl(rdx, rax); 5237 addl(rdx, rax);
5239 } 5238 }
5240 5239
5241 5240
5242 } } // namespace v8::internal 5241 } } // namespace v8::internal
5243 5242
5244 #endif // V8_TARGET_ARCH_X64 5243 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/macro-assembler-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698