Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2933613002: Add quic_test_loopback used for tests only. (Closed)

Created:
3 years, 6 months ago by Fan Yang
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add quic_test_loopback used for tests only. Merge internal change: 158527266 BUG= Review-Url: https://codereview.chromium.org/2933613002 Cr-Commit-Position: refs/heads/master@{#478613} Committed: https://chromium.googlesource.com/chromium/src/+/221f04f1ef2f889bd8452f1d0435f953b6c997ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -7 lines) Patch
M net/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/platform/api/quic_ip_address.h View 1 chunk +2 lines, -0 lines 0 comments Download
A net/quic/platform/api/quic_test_loopback.h View 1 chunk +32 lines, -0 lines 0 comments Download
A net/quic/platform/api/quic_test_loopback.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_test_loopback_impl.h View 1 chunk +29 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_test_loopback_impl.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Fan Yang
3 years, 6 months ago (2017-06-09 20:56:27 UTC) #3
Ryan Hamilton
lgtm
3 years, 6 months ago (2017-06-11 02:15:10 UTC) #8
Fan Yang
On 2017/06/11 02:15:10, Ryan Hamilton wrote: > lgtm Thanks, Ryan!
3 years, 6 months ago (2017-06-12 12:52:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933613002/1
3 years, 6 months ago (2017-06-12 12:52:21 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 14:34:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/221f04f1ef2f889bd8452f1d0435...

Powered by Google App Engine
This is Rietveld 408576698