Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2933483003: [url] Update vpython spec protobuf. (Closed)

Created:
3 years, 6 months ago by dnj
Modified:
3 years, 6 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[url] Update vpython spec protobuf. Update the "vpython" spec protobuf to accommodate the template parameter name change that was recently pushed to "vpython". BUG=None TEST=local - Ran `./recipes.py run url:examples/full` successfully. R=iannucci@chromium.org Review-Url: https://codereview.chromium.org/2933483003 Committed: https://github.com/luci/recipes-py/commit/e089e513602ea7f98d0c6478686c0919b97497fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M recipe_modules/url/resources/pycurl.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
3 years, 6 months ago (2017-06-09 15:41:09 UTC) #1
iannucci
lgtm
3 years, 6 months ago (2017-06-13 18:40:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933483003/1
3 years, 6 months ago (2017-06-13 19:08:16 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 19:11:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/e089e513602ea7f98d0c6478686c0919b97...

Powered by Google App Engine
This is Rietveld 408576698