Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2933463002: [Merge to M59] Keep the wrapper of FetchEvent alive while waiting for the preload response. (Closed)

Created:
3 years, 6 months ago by horo
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] Keep the wrapper of FetchEvent alive while waiting for the preload response. This CL uses ActiveScriptWrappable and implements HasPendingActivity() to keep the wrapper of FetchEvent alive while waiting for the preload response. FetchEvents are already kept alive by ServiceWorkerGlobalScopeProxy's |pending_preload_fetch_events_| until the preload response. But the resolver function is not called in the current implementation if GC happens. (https://crbug.com/728013#c28) That is because if the wrapper of FetchEvent are GCed, ScriptPromiseProperty can't call the resolver. BUG=728013 TBR=yhirano@chromium.org Review-Url: https://codereview.chromium.org/2922863002 Cr-Original-Commit-Position: refs/heads/master@{#476977} Review-Url: https://codereview.chromium.org/2933463002 . Cr-Commit-Position: refs/branch-heads/3071@{#764} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/8533a49fdc1c05b8b5194c58b8f5f52965e2c673

Patch Set 1 #

Messages

Total messages: 3 (2 generated)
horo
3 years, 6 months ago (2017-06-09 01:38:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8533a49fdc1c05b8b5194c58b8f5f52965e2c673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698