Chromium Code Reviews
Description[Merge to M59] Keep the wrapper of FetchEvent alive while waiting for the preload response.
This CL uses ActiveScriptWrappable and implements HasPendingActivity() to keep the wrapper of FetchEvent alive while waiting for the preload response.
FetchEvents are already kept alive by ServiceWorkerGlobalScopeProxy's |pending_preload_fetch_events_| until the preload response.
But the resolver function is not called in the current implementation if GC happens. (https://crbug.com/728013#c28)
That is because if the wrapper of FetchEvent are GCed, ScriptPromiseProperty can't call the resolver.
BUG=728013
TBR=yhirano@chromium.org
Review-Url: https://codereview.chromium.org/2922863002
Cr-Original-Commit-Position: refs/heads/master@{#476977}
Review-Url: https://codereview.chromium.org/2933463002 .
Cr-Commit-Position: refs/branch-heads/3071@{#764}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/8533a49fdc1c05b8b5194c58b8f5f52965e2c673
Patch Set 1 #Messages
Total messages: 3 (2 generated)
|