Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2933383002: [ObjC ARC] Converts ios/web:ios_web_net_unittests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), cbentzel+watch_chromium.org, ios-reviews+web_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_net_unittests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2933383002 Cr-Commit-Position: refs/heads/master@{#479388} Committed: https://chromium.googlesource.com/chromium/src/+/2d62599db9a2c87d542748c7992de0d24b32e513

Patch Set 1 #

Patch Set 2 : Fix nil assignment. #

Total comments: 2

Patch Set 3 : import -> include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -60 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/net/crw_cert_verification_controller_unittest.mm View 1 2 5 chunks +10 lines, -6 lines 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 8 chunks +21 lines, -16 lines 0 comments Download
M ios/web/net/request_group_util_unittest.mm View 1 chunk +5 lines, -2 lines 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 6 chunks +17 lines, -16 lines 0 comments Download
M ios/web/net/web_http_protocol_handler_delegate_unittest.mm View 3 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
marq (ping after 24h)
Fix nil assignment.
3 years, 6 months ago (2017-06-14 12:47:25 UTC) #5
marq (ping after 24h)
3 years, 6 months ago (2017-06-14 12:49:09 UTC) #7
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2933383002/diff/20001/ios/web/net/crw_cert_verification_controller_unittest.mm File ios/web/net/crw_cert_verification_controller_unittest.mm (right): https://codereview.chromium.org/2933383002/diff/20001/ios/web/net/crw_cert_verification_controller_unittest.mm#newcode8 ios/web/net/crw_cert_verification_controller_unittest.mm:8: #import "base/mac/foundation_util.h" nit: s/import/include
3 years, 6 months ago (2017-06-14 13:25:48 UTC) #8
marq (ping after 24h)
import -> include
3 years, 6 months ago (2017-06-14 13:33:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933383002/40001
3 years, 6 months ago (2017-06-14 13:34:02 UTC) #12
marq (ping after 24h)
Thanks for the quick review! https://codereview.chromium.org/2933383002/diff/20001/ios/web/net/crw_cert_verification_controller_unittest.mm File ios/web/net/crw_cert_verification_controller_unittest.mm (right): https://codereview.chromium.org/2933383002/diff/20001/ios/web/net/crw_cert_verification_controller_unittest.mm#newcode8 ios/web/net/crw_cert_verification_controller_unittest.mm:8: #import "base/mac/foundation_util.h" On 2017/06/14 ...
3 years, 6 months ago (2017-06-14 13:36:12 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 15:16:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2d62599db9a2c87d542748c7992d...

Powered by Google App Engine
This is Rietveld 408576698