Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2933373002: [ObjC ARC] Converts ios/web:ios_web_web_state_js_unittests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_web_state_js_unittests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2933373002 Cr-Commit-Position: refs/heads/master@{#479453} Committed: https://chromium.googlesource.com/chromium/src/+/fda6759463dc44e5c0f5b0c46e6eb23bcd6fb349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/js/common_js_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/js/context_menu_js_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_manager_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/js/crw_js_post_request_loader_unittest.mm View 3 chunks +8 lines, -6 lines 0 comments Download
M ios/web/web_state/js/crw_js_window_id_manager_unittest.mm View 4 chunks +12 lines, -8 lines 0 comments Download
M ios/web/web_state/js/page_script_util_unittest.mm View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-14 13:35:05 UTC) #8
Eugene But (OOO till 7-30)
lgtm
3 years, 6 months ago (2017-06-14 13:43:16 UTC) #9
stkhapugin
lgtm
3 years, 6 months ago (2017-06-14 17:02:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933373002/1
3 years, 6 months ago (2017-06-14 17:02:21 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 18:37:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fda6759463dc44e5c0f5b0c46e6e...

Powered by Google App Engine
This is Rietveld 408576698