Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2933353002: Forward four more BrowserAccessibility APIs to AXPlatformNode. (Closed)

Created:
3 years, 6 months ago by dougt
Modified:
3 years, 6 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward four more BrowserAccessibility APIs to AXPlatformNode. put_accValue put_accName get_accHelpTopic get_accValue To support get_accValue, we extended AXPlatformNodeBase with a number of helper methods (mostly copied from BrowserAccessibility). BUG=703369 Review-Url: https://codereview.chromium.org/2933353002 Cr-Commit-Position: refs/heads/master@{#479946} Committed: https://chromium.googlesource.com/chromium/src/+/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f

Patch Set 1 #

Patch Set 2 : Add color well and rangevalue #

Patch Set 3 : Add color well and rangevalue #

Patch Set 4 : Clean up get_accValue #

Patch Set 5 : Add new delegate method and support document get_accValue #

Patch Set 6 : Add comments. Apply range special case only when value attribute is empty #

Patch Set 7 : linux testing via try #

Total comments: 1

Patch Set 8 : Use SkColor.h instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -37 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -36 lines 0 comments Download
M ui/accessibility/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_fake_caret_win.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_fake_caret_win.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_delegate.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 2 3 4 5 6 7 2 chunks +84 lines, -1 line 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_base.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 46 (38 generated)
dougt
dmazzoni, ptal.
3 years, 6 months ago (2017-06-14 16:06:49 UTC) #24
dmazzoni
lgtm https://codereview.chromium.org/2933353002/diff/120001/ui/accessibility/platform/ax_platform_node_win.cc File ui/accessibility/platform/ax_platform_node_win.cc (right): https://codereview.chromium.org/2933353002/diff/120001/ui/accessibility/platform/ax_platform_node_win.cc#newcode560 ui/accessibility/platform/ax_platform_node_win.cc:560: // To avoid a dependency on third_party/skia, we ...
3 years, 6 months ago (2017-06-15 06:24:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933353002/140001
3 years, 6 months ago (2017-06-15 21:27:56 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/465237)
3 years, 6 months ago (2017-06-15 21:38:28 UTC) #38
dougt
hi klobag, ptal the new deps add we have on skia. thanks!
3 years, 6 months ago (2017-06-16 02:24:04 UTC) #40
klobag.chromium
lgtm
3 years, 6 months ago (2017-06-16 03:25:01 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933353002/140001
3 years, 6 months ago (2017-06-16 04:12:32 UTC) #43
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 04:17:19 UTC) #46
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/216269ac2dc0901d2ca0fd3686fb...

Powered by Google App Engine
This is Rietveld 408576698