Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2933333002: URLRequestContextBuilder: Add the ability to create a ReportingService. (Closed)

Created:
3 years, 6 months ago by mmenke
Modified:
3 years, 6 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

URLRequestContextBuilder: Add the ability to create a ReportingService. This is part of the effort to move ProfileIOData over to using a URLRequestContextBuilder (From there, we'll merge URLRequestContext creation logic in ProfileIOData and IOThread, move that into a component, have the NetworkService onto that component, and then have IOThread and ProfileIOData use an in-process Network Service to create their URLRequestContexts, and be able to expose the same API as the NetworkService for both configuration and issuing requests as well). BUG=715695 Review-Url: https://codereview.chromium.org/2933333002 Cr-Commit-Position: refs/heads/master@{#479035} Committed: https://chromium.googlesource.com/chromium/src/+/245d81e82af496cb991ef4e48629f302b5be54a8

Patch Set 1 #

Patch Set 2 : Fix declaration order #

Patch Set 3 : Juggle things around a little #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M net/url_request/url_request_context_builder.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 4 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
mmenke
I'm not adding unit tests for this, just because testing every feature of URLRequestContextBuilder in ...
3 years, 6 months ago (2017-06-13 14:24:45 UTC) #6
Julia Tuttle
lgtm!
3 years, 6 months ago (2017-06-13 14:28:24 UTC) #9
mmenke
On 2017/06/13 14:28:24, Julia Tuttle wrote: > lgtm! Thank ye kindly.
3 years, 6 months ago (2017-06-13 14:29:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933333002/40001
3 years, 6 months ago (2017-06-13 14:29:36 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 16:06:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/245d81e82af496cb991ef4e48629...

Powered by Google App Engine
This is Rietveld 408576698