Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2933323004: [merge to m60] Treat tethered networks as mobile networks (Closed)

Created:
3 years, 6 months ago by Qiang(Joe) Xu
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[merge to m60] Treat tethered networks as mobile networks merge to m60 on behalf of weidongg@ This is additional CL to support update over cellular. - add a property in NetworkState indicating tethering state. - show a warning message in about Chrome OS page on tethered networks. TBR=xiyuan@chromium.org, stevenjb@chromium.org BUG=691108 Review-Url: https://codereview.chromium.org/2919683002 Cr-Original-Commit-Position: refs/heads/master@{#476464} Review-Url: https://codereview.chromium.org/2933323004 . Cr-Commit-Position: refs/branch-heads/3112@{#334} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/caaa7bc498dc0e8d8e06732452cf57e863372464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M chrome/browser/ui/webui/help/help_utils_chromeos.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/help/help_utils_chromeos.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/settings/about_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/network/network_state.h View 4 chunks +6 lines, -0 lines 0 comments Download
M chromeos/network/network_state.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 6 months ago (2017-06-14 01:27:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
caaa7bc498dc0e8d8e06732452cf57e863372464 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698