Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2933313003: [gpu] Fix feature detection for ext_texture_norm16. (Closed)

Created:
3 years, 6 months ago by riju_
Modified:
3 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, aleksandar.stojiljkovic
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[gpu] Fix feature detection for ext_texture_norm16. ext_texture_norm16 is supported on desktop core profile (OSX and Linux) and (ANGLE on Windows). The GL version should be atleast above OpenGL 3.0 or using GL_ARB_texture_rg extension, if Chrome happens to fall back to the OpenGL compatibility profile (which is feature level 2.1 on macOS). BUG=624436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gpu/command_buffer/service/feature_info.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 9 (6 generated)
riju_
kbr@ : PTAL. As requested by you in: https://codereview.chromium.org/2920793005/diff/120001/ui/gl/gl_image_io_surface.mm#newcode35
3 years, 6 months ago (2017-06-13 14:55:14 UTC) #7
Ken Russell (switch to Gerrit)
Appreciate your eagerness to help here, but this change isn't necessary. https://codereview.chromium.org/2933313003/diff/1/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): ...
3 years, 6 months ago (2017-06-13 23:51:03 UTC) #8
riju_
3 years, 6 months ago (2017-06-14 07:18:22 UTC) #9
On 2017/06/13 23:51:03, Ken Russell wrote:
> Appreciate your eagerness to help here, but this change isn't necessary.
> 
>
https://codereview.chromium.org/2933313003/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/feature_info.cc (right):
> 
>
https://codereview.chromium.org/2933313003/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/feature_info.cc:1317:
> extensions.Contains("GL_ARB_texture_rg"))) ||
> This isn't necessary. Looking more deeply, GL_ARB_texture_rg was folded into
> OpenGL 3.0, and is_desktop_core_profile implies a minimum of OpenGL 3.2.

Thanks for the comment. I will close this issue.

Powered by Google App Engine
This is Rietveld 408576698