Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2933313003: [gpu] Fix feature detection for ext_texture_norm16. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index 8a114b4fe05ffa443364cd19e0957ca2d92673fc..8782e5288810c2e4c9ae987ca6965a8f85cf62b3 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -1312,7 +1312,9 @@ void FeatureInfo::InitializeFeatures() {
}
UMA_HISTOGRAM_BOOLEAN("GPU.TextureRG", feature_flags_.ext_texture_rg);
- if (gl_version_info_->is_desktop_core_profile ||
+ if ((gl_version_info_->is_desktop_core_profile &&
+ (gl_version_info_->IsAtLeastGL(3, 0) ||
+ extensions.Contains("GL_ARB_texture_rg"))) ||
Ken Russell (switch to Gerrit) 2017/06/13 23:51:03 This isn't necessary. Looking more deeply, GL_ARB_
extensions.Contains("GL_EXT_texture_norm16")) {
feature_flags_.ext_texture_norm16 = true;
AddExtensionString("GL_EXT_texture_norm16");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698