Generate diffs for all fields on StyleRareNonInheritedData

third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Index: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
index 5837091be1d117e3e6bd8356bb2af8964f6ead4a..641778816ab227367fcdd78f65d5ac4dadac2cf3 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
+++ b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
@@ -45,8 +45,11 @@
     {
         name: "DiffNeedsFullLayoutAndPaintInvalidation",
         fields_to_diff: ["padding-top", "padding-left", "padding-right", 
-                "padding-bottom", "-webkit-highlight", "text-indent", 
-                "text-align-last", "TextIndentLine", "EffectiveZoom", 
+                "padding-bottom", "-webkit-appearance",
+                "-webkit-margin-before-collapse",
+                "-webkit-margin-after-collapse", "-webkit-line-clamp",
+                "text-overflow", "shape-margin", "order", "-webkit-highlight",
+                "text-indent", "text-align-last", "TextIndentLine", "EffectiveZoom", 
                 "word-break", "overflow-wrap", "-webkit-line-break", 
                 "-webkit-text-security", "hyphens", "HyphenationLimitBefore", 
                 "HyphenationLimitAfter", "-webkit-hyphenate-character", 
@@ -75,6 +78,10 @@
             method: "BorderRightWidth()",
             field_dependencies: ["border-right-width"]
           },
+          {
+            method: "HasFilters()",
+            field_dependencies: ["Filter"]
+          },
           {
             method: "FontInternal().LoadingCustomFonts()",
             field_dependencies: ["font"]
@@ -183,11 +190,30 @@
     },
     {
         name: "DiffNeedsFullLayout",
-        fields_to_diff: ["width", "min-width", "max-width", "height", "min-height", "max-height", "box-sizing"]
+        fields_to_diff: ["width", "min-width", "max-width", "height", "min-height",
+        "max-height", "VerticalAlignLength", "box-sizing", "align-content",

[shend, 2017/06/13 08:15:53]

nit: indent these so that they look like they're continuing from the previous
line.

[nainar, 2017/06/14 00:29:51]

Done.

+        "align-items", "align-self", "justify-content", "justify-items",
+        "justify-self", "contain"],
+        methods_to_diff: [
+          {
+            method: "VerticalAlign()",
+            field_dependencies: ["VerticalAlign"]
+          },
+          {
+            method: "GetPosition()",
+            field_dependencies: ["position"]
+          },
+        ]
+    },
+    {
+        name: "DiffNeedsPaintInvalidationSubtree",
+        fields_to_diff: ["EffectiveBlendMode", "isolation", "Mask", "MaskBoxImage"],
     },
+
     {
         name: "DiffNeedsPaintInvalidationObject",
-        fields_to_diff: ["-webkit-user-modify", "user-select", "image-rendering"],
+        fields_to_diff: ["-webkit-user-modify", "user-select", "image-rendering",
+        "-webkit-user-drag", "object-fit", "object-position"],

[shend, 2017/06/13 08:15:53]

nit: same here.

[nainar, 2017/06/14 00:29:51]

Done.

         methods_to_diff: [
           {
             method: "Visibility()",
@@ -200,7 +226,49 @@
           {
             method: "InsideLink()",
             field_dependencies: ["InsideLink"]
-          }
+          },
+          {
+            method: "VisitedLinkBackgroundColor()",
+            field_dependencies: ["VisitedLinkBackgroundColor"]
+          },
+          {
+            method: "Resize()",
+            field_dependencies: ["resize"]
+          },
+        ],
+        predicates_to_test: [
+          {
+            predicate: "a.BoxShadowDataEquivalent(b)",
+            field_dependencies: ["text-shadow"]
+          },
+          {
+            predicate: "a.ShapeOutsideDataEquivalent(b)",
+            field_dependencies: ["shape-outside"]
+          },
+          {
+            predicate: "a.ClipPathDataEquivalent(b)",
+            field_dependencies: ["clip-path"]
+          },
+          {
+            predicate: "a.VisitedLinkBorderLeftColorHasChanged(b)",
+            field_dependencies: ["VisitedLinkBorderLeftColor"]
+          },
+          {
+            predicate: "a.VisitedLinkBorderRightColorHasChanged(b)",
+            field_dependencies: ["VisitedLinkBorderRightColor"]
+          },
+          {
+            predicate: "a.VisitedLinkBorderBottomColorHasChanged(b)",
+            field_dependencies: ["VisitedLinkBorderBottomColor"]
+          },
+          {
+            predicate: "a.VisitedLinkBorderTopColorHasChanged(b)",
+            field_dependencies: ["VisitedLinkBorderTopColor"]
+          },
+          {
+            predicate: "a.VisitedLinkOutlineColorHasChanged(b)",
+            field_dependencies: ["VisitedLinkOutlineColor"]
+          },
         ]
     },
     {
@@ -209,12 +277,63 @@
           {
             method: "Visibility()",
             field_dependencies: ["visibility"]
-          }
+          },
+          {
+            method: "Resize()",
+            field_dependencies: ["resize"]
+          },
+        ]
+    },
+    {
+        name: "UpdatePropertySpecificDifferencesZIndex",
+        fields_to_diff: ["z-index"],
+        methods_to_diff: [
+          {
+            method: "IsStackingContext()",
+            field_dependencies: ["IsStackingContext"]
+          },
+        ]
+    },
+    {
+        name: "UpdatePropertySpecificDifferencesOpacity",
+        fields_to_diff: ["opacity"],
+    },
+    {
+        name: "UpdatePropertySpecificDifferencesFilter",
+        fields_to_diff: ["Filter"],
+        predicates_to_test: [
+          {
+            predicate: "a.ReflectionDataEquivalent(b)",
+            field_dependencies: ["-webkit-box-reflect"]
+          },
         ]
     },
+    {
+        name: "UpdatePropertySpecificDifferencesNeedsRecomputeOverflow",
+        predicates_to_test: [
+          {
+            predicate: "a.BoxShadowDataEquivalent(b)",
+            field_dependencies: ["box-shadow"]
+          },
+          {
+            predicate: "a.OutlineVisuallyEqual(b)",
+            field_dependencies: ["Outline"]
+          },
+          {
+            predicate: "a.BorderVisualOverflowEqual(b)",
+            field_dependencies: ["border-image"]
+          },
+        ]
+    },
+    {
+        name: "UpdatePropertySpecificDifferencesBackdropFilter",
+        fields_to_diff: ["BackdropFilter"],
+    },
     {
         name: "UpdatePropertySpecificDifferencesTextDecorationOrColor",
-        fields_to_diff: ["TextEmphasisFill", "text-underline-position", "text-decoration-skip", "AppliedTextDecorations"],
+        fields_to_diff: ["text-decoration-style", "text-decoration-color",
+        "VisitedLinkTextDecorationColor", "TextEmphasisFill",
+        "text-underline-position", "text-decoration-skip", "AppliedTextDecorations"],
         methods_to_diff: [
           {
             method: "TextFillColor()",