Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 { | 1 { |
| 2 // This file specifies the fields we want to diff in the various diff function s | 2 // This file specifies the fields we want to diff in the various diff function s |
| 3 // in ComputedStyle. | 3 // in ComputedStyle. |
| 4 | 4 |
| 5 parameters: { | 5 parameters: { |
| 6 // The name parameter represents the name of the function to be created. | 6 // The name parameter represents the name of the function to be created. |
| 7 | 7 |
| 8 fields_to_diff: { | 8 fields_to_diff: { |
| 9 default: [], | 9 default: [], |
| 10 }, | 10 }, |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 38 methods_to_diff: [ | 38 methods_to_diff: [ |
| 39 { | 39 { |
| 40 method: "GetPosition()", | 40 method: "GetPosition()", |
| 41 field_dependencies: ["position"] | 41 field_dependencies: ["position"] |
| 42 }, | 42 }, |
| 43 ] | 43 ] |
| 44 }, | 44 }, |
| 45 { | 45 { |
| 46 name: "DiffNeedsFullLayoutAndPaintInvalidation", | 46 name: "DiffNeedsFullLayoutAndPaintInvalidation", |
| 47 fields_to_diff: ["padding-top", "padding-left", "padding-right", | 47 fields_to_diff: ["padding-top", "padding-left", "padding-right", |
| 48 "padding-bottom", "-webkit-highlight", "text-indent", | 48 "padding-bottom", "-webkit-appearance", |
| 49 "text-align-last", "TextIndentLine", "EffectiveZoom", | 49 "-webkit-margin-before-collapse", |
| 50 "-webkit-margin-after-collapse", "-webkit-line-clamp", | |
| 51 "text-overflow", "shape-margin", "order", "-webkit-highlight", | |
| 52 "text-indent", "text-align-last", "TextIndentLine", "EffectiveZo om", | |
| 50 "word-break", "overflow-wrap", "-webkit-line-break", | 53 "word-break", "overflow-wrap", "-webkit-line-break", |
| 51 "-webkit-text-security", "hyphens", "HyphenationLimitBefore", | 54 "-webkit-text-security", "hyphens", "HyphenationLimitBefore", |
| 52 "HyphenationLimitAfter", "-webkit-hyphenate-character", | 55 "HyphenationLimitAfter", "-webkit-hyphenate-character", |
| 53 "RespectImageOrientation", "-webkit-ruby-position", | 56 "RespectImageOrientation", "-webkit-ruby-position", |
| 54 "TextEmphasisMark", "TextEmphasisPosition", | 57 "TextEmphasisMark", "TextEmphasisPosition", |
| 55 "TextEmphasisCustomMark", "text-justify", "text-orientation", | 58 "TextEmphasisCustomMark", "text-justify", "text-orientation", |
| 56 "text-combine-upright", "tab-size", "text-size-adjust", | 59 "text-combine-upright", "tab-size", "text-size-adjust", |
| 57 "list-style-image", "line-height-step", | 60 "list-style-image", "line-height-step", |
| 58 "-webkit-text-stroke-width", "line-height", "font", | 61 "-webkit-text-stroke-width", "line-height", "font", |
| 59 "-webkit-border-horizontal-spacing", | 62 "-webkit-border-horizontal-spacing", |
| 60 "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"], | 63 "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"], |
| 61 methods_to_diff: [ | 64 methods_to_diff: [ |
| 62 { | 65 { |
| 63 method: "BorderLeftWidth()", | 66 method: "BorderLeftWidth()", |
| 64 field_dependencies: ["border-left-width"] | 67 field_dependencies: ["border-left-width"] |
| 65 }, | 68 }, |
| 66 { | 69 { |
| 67 method: "BorderTopWidth()", | 70 method: "BorderTopWidth()", |
| 68 field_dependencies: ["border-top-width"] | 71 field_dependencies: ["border-top-width"] |
| 69 }, | 72 }, |
| 70 { | 73 { |
| 71 method: "BorderBottomWidth()", | 74 method: "BorderBottomWidth()", |
| 72 field_dependencies: ["border-bottom-width"] | 75 field_dependencies: ["border-bottom-width"] |
| 73 }, | 76 }, |
| 74 { | 77 { |
| 75 method: "BorderRightWidth()", | 78 method: "BorderRightWidth()", |
| 76 field_dependencies: ["border-right-width"] | 79 field_dependencies: ["border-right-width"] |
| 77 }, | 80 }, |
| 78 { | 81 { |
| 82 method: "HasFilters()", | |
| 83 field_dependencies: ["Filter"] | |
| 84 }, | |
| 85 { | |
| 79 method: "FontInternal().LoadingCustomFonts()", | 86 method: "FontInternal().LoadingCustomFonts()", |
| 80 field_dependencies: ["font"] | 87 field_dependencies: ["font"] |
| 81 }, | 88 }, |
| 82 { | 89 { |
| 83 method: "HasPseudoStyle(kPseudoIdScrollbar)", | 90 method: "HasPseudoStyle(kPseudoIdScrollbar)", |
| 84 field_dependencies: ["StyleType"] | 91 field_dependencies: ["StyleType"] |
| 85 }, | 92 }, |
| 86 { | 93 { |
| 87 method: "BoxDirection()", | 94 method: "BoxDirection()", |
| 88 field_dependencies: ["-webkit-box-direction"] | 95 field_dependencies: ["-webkit-box-direction"] |
| (...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 176 field_dependencies: ["list-style-type"] | 183 field_dependencies: ["list-style-type"] |
| 177 }, | 184 }, |
| 178 { | 185 { |
| 179 method: "ListStylePosition()", | 186 method: "ListStylePosition()", |
| 180 field_dependencies: ["list-style-position"] | 187 field_dependencies: ["list-style-position"] |
| 181 }, | 188 }, |
| 182 ] | 189 ] |
| 183 }, | 190 }, |
| 184 { | 191 { |
| 185 name: "DiffNeedsFullLayout", | 192 name: "DiffNeedsFullLayout", |
| 186 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"] | 193 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", |
| 194 "max-height", "VerticalAlignLength", "box-sizing", "align-content", | |
|
shend
2017/06/13 08:15:53
nit: indent these so that they look like they're c
nainar
2017/06/14 00:29:51
Done.
| |
| 195 "align-items", "align-self", "justify-content", "justify-items", | |
| 196 "justify-self", "contain"], | |
| 197 methods_to_diff: [ | |
| 198 { | |
| 199 method: "VerticalAlign()", | |
| 200 field_dependencies: ["VerticalAlign"] | |
| 201 }, | |
| 202 { | |
| 203 method: "GetPosition()", | |
| 204 field_dependencies: ["position"] | |
| 205 }, | |
| 206 ] | |
| 187 }, | 207 }, |
| 188 { | 208 { |
| 209 name: "DiffNeedsPaintInvalidationSubtree", | |
| 210 fields_to_diff: ["EffectiveBlendMode", "isolation", "Mask", "MaskBoxImag e"], | |
| 211 }, | |
| 212 | |
| 213 { | |
| 189 name: "DiffNeedsPaintInvalidationObject", | 214 name: "DiffNeedsPaintInvalidationObject", |
| 190 fields_to_diff: ["-webkit-user-modify", "user-select", "image-rendering" ], | 215 fields_to_diff: ["-webkit-user-modify", "user-select", "image-rendering" , |
| 216 "-webkit-user-drag", "object-fit", "object-position"], | |
|
shend
2017/06/13 08:15:53
nit: same here.
nainar
2017/06/14 00:29:51
Done.
| |
| 191 methods_to_diff: [ | 217 methods_to_diff: [ |
| 192 { | 218 { |
| 193 method: "Visibility()", | 219 method: "Visibility()", |
| 194 field_dependencies: ["visibility"] | 220 field_dependencies: ["visibility"] |
| 195 }, | 221 }, |
| 196 { | 222 { |
| 197 method: "PrintColorAdjust()", | 223 method: "PrintColorAdjust()", |
| 198 field_dependencies: ["-webkit-print-color-adjust"] | 224 field_dependencies: ["-webkit-print-color-adjust"] |
| 199 }, | 225 }, |
| 200 { | 226 { |
| 201 method: "InsideLink()", | 227 method: "InsideLink()", |
| 202 field_dependencies: ["InsideLink"] | 228 field_dependencies: ["InsideLink"] |
| 203 } | 229 }, |
| 230 { | |
| 231 method: "VisitedLinkBackgroundColor()", | |
| 232 field_dependencies: ["VisitedLinkBackgroundColor"] | |
| 233 }, | |
| 234 { | |
| 235 method: "Resize()", | |
| 236 field_dependencies: ["resize"] | |
| 237 }, | |
| 238 ], | |
| 239 predicates_to_test: [ | |
| 240 { | |
| 241 predicate: "a.BoxShadowDataEquivalent(b)", | |
| 242 field_dependencies: ["text-shadow"] | |
| 243 }, | |
| 244 { | |
| 245 predicate: "a.ShapeOutsideDataEquivalent(b)", | |
| 246 field_dependencies: ["shape-outside"] | |
| 247 }, | |
| 248 { | |
| 249 predicate: "a.ClipPathDataEquivalent(b)", | |
| 250 field_dependencies: ["clip-path"] | |
| 251 }, | |
| 252 { | |
| 253 predicate: "a.VisitedLinkBorderLeftColorHasChanged(b)", | |
| 254 field_dependencies: ["VisitedLinkBorderLeftColor"] | |
| 255 }, | |
| 256 { | |
| 257 predicate: "a.VisitedLinkBorderRightColorHasChanged(b)", | |
| 258 field_dependencies: ["VisitedLinkBorderRightColor"] | |
| 259 }, | |
| 260 { | |
| 261 predicate: "a.VisitedLinkBorderBottomColorHasChanged(b)", | |
| 262 field_dependencies: ["VisitedLinkBorderBottomColor"] | |
| 263 }, | |
| 264 { | |
| 265 predicate: "a.VisitedLinkBorderTopColorHasChanged(b)", | |
| 266 field_dependencies: ["VisitedLinkBorderTopColor"] | |
| 267 }, | |
| 268 { | |
| 269 predicate: "a.VisitedLinkOutlineColorHasChanged(b)", | |
| 270 field_dependencies: ["VisitedLinkOutlineColor"] | |
| 271 }, | |
| 204 ] | 272 ] |
| 205 }, | 273 }, |
| 206 { | 274 { |
| 207 name: "DiffNeedsVisualRectUpdate", | 275 name: "DiffNeedsVisualRectUpdate", |
| 208 methods_to_diff: [ | 276 methods_to_diff: [ |
| 209 { | 277 { |
| 210 method: "Visibility()", | 278 method: "Visibility()", |
| 211 field_dependencies: ["visibility"] | 279 field_dependencies: ["visibility"] |
| 212 } | 280 }, |
| 281 { | |
| 282 method: "Resize()", | |
| 283 field_dependencies: ["resize"] | |
| 284 }, | |
| 213 ] | 285 ] |
| 214 }, | 286 }, |
| 215 { | 287 { |
| 288 name: "UpdatePropertySpecificDifferencesZIndex", | |
| 289 fields_to_diff: ["z-index"], | |
| 290 methods_to_diff: [ | |
| 291 { | |
| 292 method: "IsStackingContext()", | |
| 293 field_dependencies: ["IsStackingContext"] | |
| 294 }, | |
| 295 ] | |
| 296 }, | |
| 297 { | |
| 298 name: "UpdatePropertySpecificDifferencesOpacity", | |
| 299 fields_to_diff: ["opacity"], | |
| 300 }, | |
| 301 { | |
| 302 name: "UpdatePropertySpecificDifferencesFilter", | |
| 303 fields_to_diff: ["Filter"], | |
| 304 predicates_to_test: [ | |
| 305 { | |
| 306 predicate: "a.ReflectionDataEquivalent(b)", | |
| 307 field_dependencies: ["-webkit-box-reflect"] | |
| 308 }, | |
| 309 ] | |
| 310 }, | |
| 311 { | |
| 312 name: "UpdatePropertySpecificDifferencesNeedsRecomputeOverflow", | |
| 313 predicates_to_test: [ | |
| 314 { | |
| 315 predicate: "a.BoxShadowDataEquivalent(b)", | |
| 316 field_dependencies: ["box-shadow"] | |
| 317 }, | |
| 318 { | |
| 319 predicate: "a.OutlineVisuallyEqual(b)", | |
| 320 field_dependencies: ["Outline"] | |
| 321 }, | |
| 322 { | |
| 323 predicate: "a.BorderVisualOverflowEqual(b)", | |
| 324 field_dependencies: ["border-image"] | |
| 325 }, | |
| 326 ] | |
| 327 }, | |
| 328 { | |
| 329 name: "UpdatePropertySpecificDifferencesBackdropFilter", | |
| 330 fields_to_diff: ["BackdropFilter"], | |
| 331 }, | |
| 332 { | |
| 216 name: "UpdatePropertySpecificDifferencesTextDecorationOrColor", | 333 name: "UpdatePropertySpecificDifferencesTextDecorationOrColor", |
| 217 fields_to_diff: ["TextEmphasisFill", "text-underline-position", "text-de coration-skip", "AppliedTextDecorations"], | 334 fields_to_diff: ["text-decoration-style", "text-decoration-color", |
| 335 "VisitedLinkTextDecorationColor", "TextEmphasisFill", | |
| 336 "text-underline-position", "text-decoration-skip", "AppliedTextDecoratio ns"], | |
| 218 methods_to_diff: [ | 337 methods_to_diff: [ |
| 219 { | 338 { |
| 220 method: "TextFillColor()", | 339 method: "TextFillColor()", |
| 221 field_dependencies: ["-webkit-text-fill-color"] | 340 field_dependencies: ["-webkit-text-fill-color"] |
| 222 }, | 341 }, |
| 223 { | 342 { |
| 224 method: "TextStrokeColor()", | 343 method: "TextStrokeColor()", |
| 225 field_dependencies: ["-webkit-text-stroke-color"] | 344 field_dependencies: ["-webkit-text-stroke-color"] |
| 226 }, | 345 }, |
| 227 { | 346 { |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 245 field_dependencies: ["caret-color"] | 364 field_dependencies: ["caret-color"] |
| 246 }, | 365 }, |
| 247 { | 366 { |
| 248 method: "VisitedLinkCaretColor()", | 367 method: "VisitedLinkCaretColor()", |
| 249 field_dependencies: ["VisitedLinkCaretColor"] | 368 field_dependencies: ["VisitedLinkCaretColor"] |
| 250 }, | 369 }, |
| 251 ] | 370 ] |
| 252 }, | 371 }, |
| 253 ], | 372 ], |
| 254 } | 373 } |
| OLD | NEW |