Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2933193004:
Add the feedback about the existnce of eject device button. (Closed)
DescriptionAdd the feedback about the existnce of eject device button.
In ChromeVox, it was hard to tell there is a eject device button in
directory tree. It adds "Eject device" to aria-label of the tree item.
BUG=732202
TEST=manually with USB removable device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2933193004
Cr-Commit-Position: refs/heads/master@{#478957}
Committed: https://chromium.googlesource.com/chromium/src/+/22c0bf14345003e73ba13be78089d31f3e00bd9f
Patch Set 1 #Patch Set 2 : Remove aria-label from DeviceItem. #Messages
Total messages: 20 (14 generated)
Description was changed from ========== Add the feedback about the existnce of eject device button. In ChromeVox, it was hard to tell there is a eject device button in directory tree. It adds "Eject device" to aria-label of the tree item. BUG=732202 TEST=manually with USB removable device. ========== to ========== Add the feedback about the existnce of eject device button. In ChromeVox, it was hard to tell there is a eject device button in directory tree. It adds "Eject device" to aria-label of the tree item. BUG=732202 TEST=manually with USB removable device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tetsui@chromium.org changed reviewers: + yawano@chromium.org
PTAL. Thanks! Not sure if this is the right fix. * It looked like hard to make the eject button focusable with Search + Left / Right. I tried using aria-flowto but failed. * Not sure whether the users feel the feedback in tree level useful or redundant as I'm not familiar with ChromeVox.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yawano@chromium.org changed reviewers: + dmazzoni@chromium.org, dtseng@chromium.org
Adding dtseng@, dmazzoni@ FYI. Can we simply remove aria-label for the element? If we remove it, ChromeVox will become to read texts inside the element.
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/06/13 09:11:07, yawano wrote: > Adding dtseng@, dmazzoni@ FYI. > > Can we simply remove aria-label for the element? If we remove it, ChromeVox will > become to read texts inside the element. I removed aria-label and it works. Thank you for the advice. Still not sure about Search + Left / Right.
lgtm. Thank you. At least, it would be better if there is a feedback about the existence of the eject button.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tetsui@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497349387132450,
"parent_rev": "8cc3123c31e0538f0f10be6329683d9c698fbfed", "commit_rev":
"22c0bf14345003e73ba13be78089d31f3e00bd9f"}
Message was sent while issue was closed.
Description was changed from ========== Add the feedback about the existnce of eject device button. In ChromeVox, it was hard to tell there is a eject device button in directory tree. It adds "Eject device" to aria-label of the tree item. BUG=732202 TEST=manually with USB removable device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add the feedback about the existnce of eject device button. In ChromeVox, it was hard to tell there is a eject device button in directory tree. It adds "Eject device" to aria-label of the tree item. BUG=732202 TEST=manually with USB removable device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2933193004 Cr-Commit-Position: refs/heads/master@{#478957} Committed: https://chromium.googlesource.com/chromium/src/+/22c0bf14345003e73ba13be78089... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/22c0bf14345003e73ba13be78089... |
