[WIP] Fix periodic dumping for memory-infra on Android.

Fix periodic dumping for memory-infra on Android.

Use Tracing.start Devtools API with traceConfig instead of category 
filter. Add appropriate memory dump triggers when "memory-infra" category
is enabled.

BUG=catapult:#

[ssid, 2017-06-12 18:58:02]

Description was changed from

==========
Fix periodic dumping for memory-infra on Android.

BUG=catapult:#
==========

to

==========
Fix periodic dumping for memory-infra on Android.

BUG=catapult:#
==========

[ssid, 2017-06-12 20:46:30]

ssid@chromium.org changed reviewers:
+ fmeawad@chromium.org

[ssid, 2017-06-12 20:46:30]

+Fadi. I will add tests. I wanted to know if this CL makes sense to you. thanks!

[ssid, 2017-06-12 20:48:29]

Description was changed from

==========
Fix periodic dumping for memory-infra on Android.

BUG=catapult:#
==========

to

==========
Fix periodic dumping for memory-infra on Android.

Use Tracing.start Devtools API with traceConfig instead of category 
filter. Add appropriate memory dump triggers when "memory-infra" category
is enabled.

BUG=catapult:#
==========

[ssid, 2017-06-13 21:38:26]

ping Fadi.

[fmeawad, 2017-06-14 17:18:36]

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
File
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
(left):

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html:100:
(recordingOptions.useSampling ? 'enable-sampling' : '')
This was for the old sampling code that was removed?

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
File
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
(right):

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html:109:
traceConfig: trace_config_str,
Should we be concerned about the string size? give that we list all the
categories?

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
File tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
(right):

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html:510: if
(disabled) {
Shouldn't this be if (!disabled)? If this is not the case, then variable names
are confusing

[ssid, 2017-06-20 21:58:41]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 21:58:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 22:00:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 22:01:00]

Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[ssid, 2017-06-20 22:02:45]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 22:02:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 22:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 22:05:00]

Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[ssid, 2017-06-21 18:38:16]

Closing this issue since Eirk is taking over. Some replies for Fadi's reference.
Thanks!

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
File
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
(left):

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html:100:
(recordingOptions.useSampling ? 'enable-sampling' : '')
On 2017/06/14 17:18:36, fmeawad wrote:
> This was for the old sampling code that was removed?

Sorry this should be fixed in Eirk's cl.

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
File
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
(right):

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html:109:
traceConfig: trace_config_str,
On 2017/06/14 17:18:36, fmeawad wrote:
> Should we be concerned about the string size? give that we list all the
> categories?

I think it was the same earlier as well. We used to add category filter with all
category names and exlcluded ones with '-'. So, size should not very much.

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
File tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
(right):

https://codereview.chromium.org/2933193002/diff/1/tracing/tracing/ui/extras/a...
tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html:510: if
(disabled) {
On 2017/06/14 17:18:36, fmeawad wrote:
> Shouldn't this be if (!disabled)? If this is not the case, then variable names
> are confusing

Um ,no. We add "disabled-by-default" categories to included list if it's ticked
in UI. We add normal categories to excluded list if it's not ticked in the UI.
So, if (disabled) here and if(!disabled) below.