Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html

Issue 2933193002: [WIP] Fix periodic dumping for memory-infra on Android. (Closed)
Patch Set: fix normal tracing. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/ui/extras/about_tracing/record_controller.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
diff --git a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
index 0971bb93c1395a7f0d40c2a79229bfe811119706..97bc178803faa101ee94292a2b3f7be0a09f3681 100644
--- a/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
+++ b/tracing/tracing/ui/extras/about_tracing/inspector_tracing_controller_client.html
@@ -87,18 +87,27 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
},
beginRecording(recordingOptions) {
+ alert("beginRecording");
if (this.recording_) {
throw new Error('Already recording');
}
this.recording_ = 'starting';
+ var memory_config = { triggers: [] };
+ if (recordingOptions.includedCategories.indexOf('disabled-by-default-memory-infra') !== -1) {
+ memory_config.triggers.push(
+ {'mode': 'detailed', 'periodic_interval_ms': 10000});
+ }
+ var trace_config_str = {
+ includedCategories: recordingOptions.includedCategories,
+ excludedCategories: recordingOptions.excludedCategories,
+ memoryDumpConfig: memory_config,
+ recordMode: "record-until-full"
+ };
+ alert(recordingOptions.tracingRecordMode);
let res = this.conn_.req(
'Tracing.start',
{
- categories: recordingOptions.categoryFilter,
- options:
- [recordingOptions.tracingRecordMode,
- (recordingOptions.useSampling ? 'enable-sampling' : '')
- ].join(','),
+ traceConfig: trace_config_str,
bufferUsageReportingInterval: 1000
});
res = res.then(
« no previous file with comments | « no previous file | tracing/tracing/ui/extras/about_tracing/record_controller.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698