Photo Picker dialog: Add UMA for file enumeration.

Photo Picker dialog: Add UMA for file enumeration.

BUG=656015
Review-Url: https://codereview.chromium.org/2933173003
Cr-Commit-Position: refs/heads/master@{#479162}
Committed: https://chromium.googlesource.com/chromium/src/+/9fc9d951c4b4757038d8ae9dbeafd43bea88aab3

[Finnur, 2017-06-13 14:38:02]

Description was changed from

==========
Photo Picker dialog: Add UMA for file enumeration.

BUG=656015
==========

to

==========
Photo Picker dialog: Add UMA for file enumeration.

BUG=656015
==========

[Finnur, 2017-06-13 14:38:02]

finnur@chromium.org changed reviewers:
+ twellington@chromium.org

[Finnur, 2017-06-13 14:38:58]

finnur@chromium.org changed reviewers:
+ isherman@chromium.org

[Finnur, 2017-06-13 14:39:04]

PTAL

[Theresa, 2017-06-13 15:11:36]

lgtm

https://codereview.chromium.org/2933173003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
(right):

https://codereview.chromium.org/2933173003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:224:
int rate = (int) (100 * files.size() / elapsedTimeMs);
nit: Add a comment here that enumerated rate is per 10th of a second so that the
its more obvious why we're multiplying by 100

[Finnur, 2017-06-13 15:53:04]

https://codereview.chromium.org/2933173003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
(right):

https://codereview.chromium.org/2933173003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:224:
int rate = (int) (100 * files.size() / elapsedTimeMs);
Should I move the comment on line 222 down one line or reword it to make it
clearer?

[Finnur, 2017-06-13 16:04:17]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 16:04:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-06-13 16:06:03]

https://codereview.chromium.org/2933173003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
(right):

https://codereview.chromium.org/2933173003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java:224:
int rate = (int) (100 * files.size() / elapsedTimeMs);
On 2017/06/13 15:53:04, Finnur wrote:
> Should I move the comment on line 222 down one line or reword it to make it
> clearer?

Oh.. No. The comment you have is fine. Sorry.

[Finnur, 2017-06-13 16:19:28]

No problem. Thanks for the review!

Ilya, if this is worthy of the green light, then feel free to tick the CQ box.

[commit-bot: I haz the power, 2017-06-13 17:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:00:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Finnur, 2017-06-13 17:05:20]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 17:05:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:11:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Finnur, 2017-06-13 19:49:59]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 19:51:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 20:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 20:48:32]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-06-13 21:32:01]

Metrics LGTM, thanks.

[Ilya Sherman, 2017-06-13 21:32:19]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:33:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:40:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497389539523160, "parent_rev":
"eaa976b4923b9c257b9d79912a852403cffaf3f0", "commit_rev":
"9fc9d951c4b4757038d8ae9dbeafd43bea88aab3"}

[commit-bot: I haz the power, 2017-06-13 21:40:43]

Description was changed from

==========
Photo Picker dialog: Add UMA for file enumeration.

BUG=656015
==========

to

==========
Photo Picker dialog: Add UMA for file enumeration.

BUG=656015

Review-Url: https://codereview.chromium.org/2933173003
Cr-Commit-Position: refs/heads/master@{#479162}
Committed:
https://chromium.googlesource.com/chromium/src/+/9fc9d951c4b4757038d8ae9dbeaf...
==========

[commit-bot: I haz the power, 2017-06-13 21:40:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9fc9d951c4b4757038d8ae9dbeaf...