predictors: Improve comment clarity and remove unecessary namespace specifiers.

predictors: Improve comment clarity and remove unecessary namespace specifiers.

BUG=715525
Review-Url: https://codereview.chromium.org/2933133003
Cr-Commit-Position: refs/heads/master@{#479004}
Committed: https://chromium.googlesource.com/chromium/src/+/b2565454f397846a83afc020c3fbd1d31766e03a

[trevordixon, 2017-06-13 11:50:22]

trevordixon@chromium.org changed reviewers:
+ alexilin@chromium.org, pasko@chromium.org

[trevordixon, 2017-06-13 11:50:50]

https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/l...
File chrome/browser/predictors/loading_data_collector.h (right):

https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/l...
chrome/browser/predictors/loading_data_collector.h:20: // reported by various
observers. All the non-static methods of this class need
In response to this comment from pasko on a previous CL
(https://codereview.chromium.org/2896713003/diff/20001/chrome/browser/predicto...):
"Does this say that the observers of the database record navigation events? I
thought it's the other way around - navigation observers are used for recording
events and updating the database."

It's ambiguous as written. Observers report events to this LoadingDataCollector,
then LoadingDataCollector records to the database and stats collection classes.
Hopefully this change makes it clear?

https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/l...
chrome/browser/predictors/loading_data_collector.h:25: explicit
LoadingDataCollector(ResourcePrefetchPredictor* predictor);
Got rid of unnecessary predictors:: namespace specifier.

(In response to a comment from alexilin on a previous CL.)

[alexilin, 2017-06-13 12:01:26]

lgtm, thanks for the cleanup.

[pasko, 2017-06-13 12:53:29]

LGTM, thank you

https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/l...
File chrome/browser/predictors/loading_data_collector.h (right):

https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/l...
chrome/browser/predictors/loading_data_collector.h:20: // reported by various
observers. All the non-static methods of this class need
On 2017/06/13 11:50:49, trevordixon wrote:
> In response to this comment from pasko on a previous CL
>
(https://codereview.chromium.org/2896713003/diff/20001/chrome/browser/predicto...):
> "Does this say that the observers of the database record navigation events? I
> thought it's the other way around - navigation observers are used for
recording
> events and updating the database."
> 
> It's ambiguous as written. Observers report events to this
LoadingDataCollector,
> then LoadingDataCollector records to the database and stats collection
classes.
> Hopefully this change makes it clear?

Yes, it makes it much clearer, thank you.

[trevordixon, 2017-06-13 13:11:53]

The CQ bit was checked by trevordixon@chromium.org

[commit-bot: I haz the power, 2017-06-13 13:12:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 14:09:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497359513393790, "parent_rev":
"dcd54689343f21757d91f8411868509e618e93fc", "commit_rev":
"b2565454f397846a83afc020c3fbd1d31766e03a"}

[commit-bot: I haz the power, 2017-06-13 14:09:35]

Description was changed from

==========
predictors: Improve comment clarity and remove unecessary namespace specifiers.

BUG=715525
==========

to

==========
predictors: Improve comment clarity and remove unecessary namespace specifiers.

BUG=715525

Review-Url: https://codereview.chromium.org/2933133003
Cr-Commit-Position: refs/heads/master@{#479004}
Committed:
https://chromium.googlesource.com/chromium/src/+/b2565454f397846a83afc020c3fb...
==========

[commit-bot: I haz the power, 2017-06-13 14:09:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2565454f397846a83afc020c3fb...