Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2933133003: predictors: Improve comment clarity and remove unecessary namespace specifiers. (Closed)

Created:
3 years, 6 months ago by trevordixon
Modified:
3 years, 6 months ago
Reviewers:
pasko, alexilin
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Improve comment clarity and remove unecessary namespace specifiers. BUG=715525 Review-Url: https://codereview.chromium.org/2933133003 Cr-Commit-Position: refs/heads/master@{#479004} Committed: https://chromium.googlesource.com/chromium/src/+/b2565454f397846a83afc020c3fbd1d31766e03a

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/predictors/loading_data_collector.h View 3 chunks +7 lines, -8 lines 3 comments Download

Messages

Total messages: 9 (4 generated)
trevordixon
https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/loading_data_collector.h File chrome/browser/predictors/loading_data_collector.h (right): https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/loading_data_collector.h#newcode20 chrome/browser/predictors/loading_data_collector.h:20: // reported by various observers. All the non-static methods ...
3 years, 6 months ago (2017-06-13 11:50:50 UTC) #2
alexilin
lgtm, thanks for the cleanup.
3 years, 6 months ago (2017-06-13 12:01:26 UTC) #3
pasko
LGTM, thank you https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/loading_data_collector.h File chrome/browser/predictors/loading_data_collector.h (right): https://codereview.chromium.org/2933133003/diff/1/chrome/browser/predictors/loading_data_collector.h#newcode20 chrome/browser/predictors/loading_data_collector.h:20: // reported by various observers. All ...
3 years, 6 months ago (2017-06-13 12:53:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933133003/1
3 years, 6 months ago (2017-06-13 13:12:07 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 14:09:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2565454f397846a83afc020c3fb...

Powered by Google App Engine
This is Rietveld 408576698