[ObjC ARC] Converts ios/chrome/browser/ui/overscroll_actions:overscroll_actions to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/overscroll_actions:overscroll_actions to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933123002
Cr-Commit-Position: refs/heads/master@{#478739}
Committed: https://chromium.googlesource.com/chromium/src/+/41757e52bacb2dd4ba55823e49bb16cc96347cb4

[marq (ping after 24h), 2017-06-12 15:41:26]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 15:42:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 15:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 15:54:06]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[marq (ping after 24h), 2017-06-12 18:08:20]

marq@chromium.org changed reviewers:
+ jif@chromium.org, stkhapugin@chromium.org

[jif, 2017-06-12 18:18:24]

lgtm with question

https://codereview.chromium.org/2933123002/diff/1/ios/chrome/browser/ui/overs...
File
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm
(right):

https://codereview.chromium.org/2933123002/diff/1/ios/chrome/browser/ui/overs...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm:35:
#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
Are we OK to live with this?

[marq (ping after 24h), 2017-06-12 18:21:48]

https://codereview.chromium.org/2933123002/diff/1/ios/chrome/browser/ui/overs...
File
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm
(right):

https://codereview.chromium.org/2933123002/diff/1/ios/chrome/browser/ui/overs...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm:35:
#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
On 2017/06/12 18:18:24, jif wrote:
> Are we OK to live with this?

We don't really have an option, since the compiler has no way of knowing what
the selector is and what's going to happen to the object. It's how we've handled
ARC-transitioning other -performSelector:withObject calls:.

(The proper solution is not to pass objects into arbitrary selectors).

[jif, 2017-06-12 18:22:25]

Thanks. TIL :-)
Full lgtm.

[marq (ping after 24h), 2017-06-12 20:08:56]

The CQ bit was checked by marq@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:09:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:15:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497298136931000, "parent_rev":
"698863fd7bbf3a52bfe40625b0eb8044701430c8", "commit_rev":
"41757e52bacb2dd4ba55823e49bb16cc96347cb4"}

[commit-bot: I haz the power, 2017-06-12 20:15:55]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/overscroll_actions:overscroll_actions
to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/overscroll_actions:overscroll_actions
to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933123002
Cr-Commit-Position: refs/heads/master@{#478739}
Committed:
https://chromium.googlesource.com/chromium/src/+/41757e52bacb2dd4ba55823e49bb...
==========

[commit-bot: I haz the power, 2017-06-12 20:15:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41757e52bacb2dd4ba55823e49bb...