[ObjC ARC] Converts ios/chrome/browser/autofill:autofill to ARC.

[ObjC ARC] Converts ios/chrome/browser/autofill:autofill to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933093003
Cr-Commit-Position: refs/heads/master@{#479441}
Committed: https://chromium.googlesource.com/chromium/src/+/8e801e6689132cd4ea63e6bfa46d0774ea77018e

[marq (ping after 24h), 2017-06-12 12:56:23]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 12:56:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 14:25:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 14:25:22]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[marq (ping after 24h), 2017-06-13 10:23:02]

Fix nil assignment.

[marq (ping after 24h), 2017-06-13 10:26:03]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 10:26:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-13 11:03:11]

marq@chromium.org changed reviewers:
+ jdonnelly@chromium.org, stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-06-13 11:53:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 11:53:12]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-06-13 12:28:25]

lgtm

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
File ios/chrome/browser/autofill/form_input_accessory_view_controller.h (right):

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
ios/chrome/browser/autofill/form_input_accessory_view_controller.h:86:
@property(weak, nonatomic, readonly) id<CRWWebViewProxy> webViewProxy;
I think it's more of a strong, as it's a getter that returns something owned by
the child that this owns.

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
File ios/chrome/browser/autofill/form_suggestion_controller.h (right):

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
ios/chrome/browser/autofill/form_suggestion_controller.h:49: @property(weak,
nonatomic, readonly) id<FormInputAccessoryViewProvider>
definitely strong, as this is returning |self|

[marq (ping after 24h), 2017-06-13 12:35:30]

Made some weak properties strong.

[marq (ping after 24h), 2017-06-13 12:36:22]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 12:36:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-13 12:36:33]

Thanks!

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
File ios/chrome/browser/autofill/form_input_accessory_view_controller.h (right):

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
ios/chrome/browser/autofill/form_input_accessory_view_controller.h:86:
@property(weak, nonatomic, readonly) id<CRWWebViewProxy> webViewProxy;
On 2017/06/13 12:28:25, stkhapugin wrote:
> I think it's more of a strong, as it's a getter that returns something owned
by
> the child that this owns. 

Done.

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
File ios/chrome/browser/autofill/form_suggestion_controller.h (right):

https://codereview.chromium.org/2933093003/diff/20001/ios/chrome/browser/auto...
ios/chrome/browser/autofill/form_suggestion_controller.h:49: @property(weak,
nonatomic, readonly) id<FormInputAccessoryViewProvider>
On 2017/06/13 12:28:25, stkhapugin wrote:
> definitely strong, as this is returning |self|

Done.

[commit-bot: I haz the power, 2017-06-13 14:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 14:00:29]

Dry run: This issue passed the CQ dry run.

[Justin Donnelly, 2017-06-13 20:08:05]

https://codereview.chromium.org/2933093003/diff/40001/ios/chrome/browser/auto...
File ios/chrome/browser/autofill/form_input_accessory_view.mm (right):

https://codereview.chromium.org/2933093003/diff/40001/ios/chrome/browser/auto...
ios/chrome/browser/autofill/form_input_accessory_view.mm:129: _customView = nil;
Shouldn't this be _customView = customView; ?

[marq (ping after 24h), 2017-06-14 12:05:41]

Fix nil assignment.

[marq (ping after 24h), 2017-06-14 12:06:13]

Thanks, PTAL.

https://codereview.chromium.org/2933093003/diff/40001/ios/chrome/browser/auto...
File ios/chrome/browser/autofill/form_input_accessory_view.mm (right):

https://codereview.chromium.org/2933093003/diff/40001/ios/chrome/browser/auto...
ios/chrome/browser/autofill/form_input_accessory_view.mm:129: _customView = nil;
On 2017/06/13 20:08:05, Justin Donnelly wrote:
> Shouldn't this be _customView = customView; ?

It should have been, yes. But it looks like it doesn't matter, since the
argument |customView| is added as a subview, and nothing else after object init
cares about the _customView ivar (as far as I could tell).

So: fixed, but maybe someone should just get rid of the ivar.

[Justin Donnelly, 2017-06-14 14:11:42]

lgtm

[marq (ping after 24h), 2017-06-14 14:16:42]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-14 14:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2933093003/#ps60001
(title: "Fix nil assignment.")

[commit-bot: I haz the power, 2017-06-14 14:16:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 16:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 16:18:36]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[marq (ping after 24h), 2017-06-14 17:03:11]

The CQ bit was checked by marq@chromium.org

[stkhapugin, 2017-06-14 17:03:25]

lgtm

[commit-bot: I haz the power, 2017-06-14 17:03:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 18:02:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497459791856930,
"parent_rev": "a277580f50c1ea6ba323677db85fbd9ba56d9df3", "commit_rev":
"8e801e6689132cd4ea63e6bfa46d0774ea77018e"}

[commit-bot: I haz the power, 2017-06-14 18:02:30]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/autofill:autofill to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/autofill:autofill to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2933093003
Cr-Commit-Position: refs/heads/master@{#479441}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e801e6689132cd4ea63e6bfa46d...
==========

[commit-bot: I haz the power, 2017-06-14 18:02:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8e801e6689132cd4ea63e6bfa46d...