Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: pkg/compiler/lib/src/kernel/element_map_impl.dart

Issue 2933093002: Revert "Handle named mixin application in emitter" (Closed)
Patch Set: Add bug numbers. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/element_map_impl.dart
diff --git a/pkg/compiler/lib/src/kernel/element_map_impl.dart b/pkg/compiler/lib/src/kernel/element_map_impl.dart
index ee77675d692c9439355f951c02c8075859ca9d7a..7a29d03b2f46b094cf3dfd842cd14270c79edbb6 100644
--- a/pkg/compiler/lib/src/kernel/element_map_impl.dart
+++ b/pkg/compiler/lib/src/kernel/element_map_impl.dart
@@ -524,7 +524,6 @@ class KernelToElementMapImpl extends KernelToElementMapMixin {
if (node.supertype == null) {
env.orderedTypeSet = new OrderedTypeSet.singleton(env.thisType);
- env.isMixinApplication = false;
} else {
InterfaceType processSupertype(ir.Supertype node) {
InterfaceType type = _typeConverter.visitSupertype(node);
@@ -538,11 +537,8 @@ class KernelToElementMapImpl extends KernelToElementMapMixin {
LinkBuilder<InterfaceType> linkBuilder =
new LinkBuilder<InterfaceType>();
if (node.mixedInType != null) {
- env.isMixinApplication = true;
linkBuilder
.addLast(env.mixedInType = processSupertype(node.mixedInType));
- } else {
- env.isMixinApplication = false;
}
node.implementedTypes.forEach((ir.Supertype supertype) {
linkBuilder.addLast(processSupertype(supertype));
@@ -585,12 +581,6 @@ class KernelToElementMapImpl extends KernelToElementMapMixin {
return env.supertype;
}
- bool _isMixinApplication(KClass cls) {
- _KClassEnv env = _classEnvs[cls.classIndex];
- _ensureSupertypes(cls, env);
- return env.isMixinApplication;
- }
-
bool _isUnnamedMixinApplication(KClass cls) {
_KClassEnv env = _classEnvs[cls.classIndex];
_ensureSupertypes(cls, env);
@@ -881,7 +871,6 @@ class _KLibraryEnv {
/// Environment for fast lookup of class members.
class _KClassEnv {
final ir.Class cls;
- bool isMixinApplication;
final bool isUnnamedMixinApplication;
InterfaceType thisType;
@@ -1151,11 +1140,6 @@ class KernelElementEnvironment implements ElementEnvironment {
return getThisType(cls).typeArguments.isNotEmpty;
}
- @override
- bool isMixinApplication(KClass cls) {
- return elementMap._isMixinApplication(cls);
- }
-
@override
bool isUnnamedMixinApplication(KClass cls) {
return elementMap._isUnnamedMixinApplication(cls);
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | pkg/compiler/lib/src/kernel/task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698