Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h

Issue 2933023002: PaymentHandler: PaymentRequestEvent.total should be |object| type. (Closed)
Patch Set: yaho Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
index 28e364f6070c22adc7633f85f2f4b445e862275e..9887c1093d9de4a0310b4f9057c4e8f73f72a618 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.h
@@ -5,6 +5,7 @@
#ifndef PaymentRequestEvent_h
#define PaymentRequestEvent_h
+#include "bindings/core/v8/ScriptValue.h"
#include "modules/EventModules.h"
#include "modules/payments/PaymentRequestEventInit.h"
#include "modules/serviceworkers/ExtendableEvent.h"
@@ -17,6 +18,7 @@ class AtomicString;
namespace blink {
class RespondWithObserver;
+class ScriptState;
class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
DEFINE_WRAPPERTYPEINFO();
@@ -37,7 +39,7 @@ class MODULES_EXPORT PaymentRequestEvent final : public ExtendableEvent {
const String& paymentRequestOrigin() const;
const String& paymentRequestId() const;
const HeapVector<PaymentMethodData>& methodData() const;
- void total(PaymentItem& value) const;
+ const ScriptValue total(ScriptState*) const;
const HeapVector<PaymentDetailsModifier>& modifiers() const;
const String& instrumentKey() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698