Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1978)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp

Issue 2933023002: PaymentHandler: PaymentRequestEvent.total should be |object| type. (Closed)
Patch Set: yaho Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
index bdf533512892cf05a55a6e4091717f80b8fd6abc..c4e1e4c5b44ea4162daca63a1a7a28a31dba0d64 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
@@ -11,6 +11,7 @@
#include "modules/serviceworkers/RespondWithObserver.h"
#include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"
#include "modules/serviceworkers/ServiceWorkerWindowClientCallback.h"
+#include "platform/bindings/ScriptState.h"
#include "platform/wtf/PtrUtil.h"
#include "platform/wtf/text/AtomicString.h"
@@ -53,8 +54,8 @@ const HeapVector<PaymentMethodData>& PaymentRequestEvent::methodData() const {
return method_data_;
}
-void PaymentRequestEvent::total(PaymentItem& value) const {
- value = total_;
+const ScriptValue PaymentRequestEvent::total(ScriptState* script_state) const {
+ return ScriptValue::From(script_state, total_);
}
const HeapVector<PaymentDetailsModifier>& PaymentRequestEvent::modifiers()

Powered by Google App Engine
This is Rietveld 408576698