Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2932913003: MD Settings, cleanup: Remove obsolete references to paper-dialog, paper-item. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings, cleanup: Remove obsolete references to paper-dialog, paper-item. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2932913003 Cr-Commit-Position: refs/heads/master@{#478699} Committed: https://chromium.googlesource.com/chromium/src/+/c801f245e80080ae7e3ca6323ac43f8f793c32e1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.js View 1 chunk +1 line, -1 line 2 comments Download
M chrome/browser/resources/settings/settings_vars_css.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
dpapad
3 years, 6 months ago (2017-06-09 23:41:25 UTC) #6
dschuyler
lgtm https://codereview.chromium.org/2932913003/diff/1/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js File chrome/browser/resources/settings/languages_page/edit_dictionary_page.js (right): https://codereview.chromium.org/2932913003/diff/1/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js#newcode114 chrome/browser/resources/settings/languages_page/edit_dictionary_page.js:114: * Handles tapping on a "Remove word" icon ...
3 years, 6 months ago (2017-06-10 01:41:49 UTC) #9
dpapad
https://codereview.chromium.org/2932913003/diff/1/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js File chrome/browser/resources/settings/languages_page/edit_dictionary_page.js (right): https://codereview.chromium.org/2932913003/diff/1/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js#newcode114 chrome/browser/resources/settings/languages_page/edit_dictionary_page.js:114: * Handles tapping on a "Remove word" icon button. ...
3 years, 6 months ago (2017-06-12 17:17:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932913003/1
3 years, 6 months ago (2017-06-12 17:18:05 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 18:49:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c801f245e80080ae7e3ca6323ac4...

Powered by Google App Engine
This is Rietveld 408576698