Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTheme.h

Issue 2932913002: Move spellcheck underline colors into LayoutTheme (Closed)
Patch Set: Fix Mac build Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTheme.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTheme.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTheme.h b/third_party/WebKit/Source/core/layout/LayoutTheme.h
index e87c075406884822ff905cf1e4a1c5a284397020..4650147fef6f23eaa64f6bc5bd32cbd4dceb6f2d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTheme.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTheme.h
@@ -130,6 +130,10 @@ class CORE_EXPORT LayoutTheme : public RefCounted<LayoutTheme> {
Color InactiveListBoxSelectionBackgroundColor() const;
Color InactiveListBoxSelectionForegroundColor() const;
+ // Underline colors for spelling and grammar markers.
chrishtr 2017/06/10 00:45:56 I think this comment is redundant, you can just re
+ Color SpellingMarkerUnderlineColor() const;
+ Color GrammarMarkerUnderlineColor() const;
chrishtr 2017/06/10 00:45:56 What's the point of having these extra methods?
rlanday 2017/06/10 16:34:03 I'm not sure, I was just copying how the existing
+
// Highlight and text colors for TextMatches.
Color PlatformTextSearchHighlightColor(bool active_match) const;
Color PlatformTextSearchColor(bool active_match) const;
@@ -238,6 +242,9 @@ class CORE_EXPORT LayoutTheme : public RefCounted<LayoutTheme> {
virtual Color PlatformActiveListBoxSelectionForegroundColor() const;
virtual Color PlatformInactiveListBoxSelectionForegroundColor() const;
+ virtual Color PlatformSpellingMarkerUnderlineColor() const;
+ virtual Color PlatformGrammarMarkerUnderlineColor() const;
+
virtual bool ThemeDrawsFocusRing(const ComputedStyle&) const = 0;
// Methods for each appearance value.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTheme.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698