Move spellcheck underline colors into LayoutTheme

third_party/WebKit/Source/core/layout/LayoutTheme.h

 /*
  * This file is part of the theme implementation for form controls in WebCore.
  *
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 112 matching lines @@
   Color InactiveSelectionBackgroundColor() const;
   Color ActiveSelectionForegroundColor() const;
   Color InactiveSelectionForegroundColor() const;
 
   // List box selection colors
   Color ActiveListBoxSelectionBackgroundColor() const;
   Color ActiveListBoxSelectionForegroundColor() const;
   Color InactiveListBoxSelectionBackgroundColor() const;
   Color InactiveListBoxSelectionForegroundColor() const;
 
+  // Underline colors for spelling and grammar markers.

[chrishtr, 2017/06/10 00:45:56]

I think this comment is redundant, you can just remove it.

+  Color SpellingMarkerUnderlineColor() const;
+  Color GrammarMarkerUnderlineColor() const;

[chrishtr, 2017/06/10 00:45:56]

What's the point of having these extra methods?

[rlanday, 2017/06/10 16:34:03]

I'm not sure, I was just copying how the existing methods are set up...

+
   // Highlight and text colors for TextMatches.
   Color PlatformTextSearchHighlightColor(bool active_match) const;
   Color PlatformTextSearchColor(bool active_match) const;
 
   Color FocusRingColor() const;
   virtual Color PlatformFocusRingColor() const { return Color(0, 0, 0); }
   void SetCustomFocusRingColor(const Color&);
   static Color TapHighlightColor();
   virtual Color PlatformTapHighlightColor() const {
     return LayoutTheme::kDefaultTapHighlightColor;
@@ skipping 88 matching lines @@
   virtual Color PlatformActiveSelectionBackgroundColor() const;
   virtual Color PlatformInactiveSelectionBackgroundColor() const;
   virtual Color PlatformActiveSelectionForegroundColor() const;
   virtual Color PlatformInactiveSelectionForegroundColor() const;
 
   virtual Color PlatformActiveListBoxSelectionBackgroundColor() const;
   virtual Color PlatformInactiveListBoxSelectionBackgroundColor() const;
   virtual Color PlatformActiveListBoxSelectionForegroundColor() const;
   virtual Color PlatformInactiveListBoxSelectionForegroundColor() const;
 
+  virtual Color PlatformSpellingMarkerUnderlineColor() const;
+  virtual Color PlatformGrammarMarkerUnderlineColor() const;
+
   virtual bool ThemeDrawsFocusRing(const ComputedStyle&) const = 0;
 
   // Methods for each appearance value.
   virtual void AdjustCheckboxStyle(ComputedStyle&) const;
   virtual void SetCheckboxSize(ComputedStyle&) const {}
 
   virtual void AdjustRadioStyle(ComputedStyle&) const;
   virtual void SetRadioSize(ComputedStyle&) const {}
 
   virtual void AdjustButtonStyle(ComputedStyle&) const;
@@ skipping 39 matching lines @@
   static const RGBA32 kDefaultTapHighlightColor = 0x66000000;
 
   static const RGBA32 kDefaultCompositionBackgroundColor = 0xFFFFDD55;
 
   Theme* platform_theme_;  // The platform-specific theme.
 };
 
 }  // namespace blink
 
 #endif  // LayoutTheme_h