Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2932863002: Enable PasswordGenerationInteractiveTest.PopupShownAndPasswordSelected (Closed)

Created:
3 years, 6 months ago by vasilii
Modified:
3 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PasswordGenerationInteractiveTest.PopupShownAndPasswordSelected The test is fixed after https://codereview.chromium.org/2924873007/ landed BUG=407998 Review-Url: https://codereview.chromium.org/2932863002 Cr-Commit-Position: refs/heads/master@{#478571} Committed: https://chromium.googlesource.com/chromium/src/+/e799795eedf8f28d8beaa2e2fa25667e5afcbd4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/password_manager/password_generation_interactive_uitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
vasilii
Hi Vaclav, please review.
3 years, 6 months ago (2017-06-09 18:37:06 UTC) #4
vabr (Chromium)
Thanks, Vasilii, LGTM. Great job fixing and investigating in detail in https://codereview.chromium.org/2924873007/! Vaclav
3 years, 6 months ago (2017-06-10 12:54:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932863002/1
3 years, 6 months ago (2017-06-12 08:38:37 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 09:10:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e799795eedf8f28d8beaa2e2fa25...

Powered by Google App Engine
This is Rietveld 408576698