Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2932853002: Fix signed integers in track_run_iterator.cc (Closed)

Created:
3 years, 6 months ago by servolk
Modified:
3 years, 6 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix signed integers in track_run_iterator.cc Sample sizes and durations in MP4 TRUN box are unsigned 32-bit integers per ISO BMFF Byte Stream Format spec (see ISO/IEC 14496-12 section 8.8.8.2 describing syntax of TrackRunBox). They are correctly declared as unsigned ints in box_definitions.h, but incorrectly declared as signed integers in track_run_iterator.cc Review-Url: https://codereview.chromium.org/2932853002 Cr-Commit-Position: refs/heads/master@{#478396} Committed: https://chromium.googlesource.com/chromium/src/+/15d1b34174529968cac05a8902c96368687a8fd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/formats/mp4/track_run_iterator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
servolk
3 years, 6 months ago (2017-06-09 18:07:23 UTC) #4
wolenetz
lgtm -- are there any tests that were failing or a related crbug?
3 years, 6 months ago (2017-06-09 18:27:14 UTC) #6
servolk
On 2017/06/09 18:27:14, wolenetz wrote: > lgtm -- are there any tests that were failing ...
3 years, 6 months ago (2017-06-09 19:34:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932853002/1
3 years, 6 months ago (2017-06-09 19:34:42 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 20:29:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15d1b34174529968cac05a8902c9...

Powered by Google App Engine
This is Rietveld 408576698