Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2932833002: PPC/s390: [builtins] Start refactoring the Apply builtin. (Closed)

Created:
3 years, 6 months ago by JaideepBajwa
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Start refactoring the Apply builtin. Port af76779aa3064a8d5ce8f7b88836110f3de4cfa0 Original Commit Message: This splits the monolithic Apply builtin into several smaller builtins, namely CallVargargs and ConstructVarargs, which accept a length and a FixedArray of elements and deal with the actual stack manipulation, and CallWithArrayLike / ConstructWithArrayLike that deal with getting the elements from the receiver (for Function.prototype.apply, Reflect.apply and Reflect.construct), which can now be written using the CSA. The idea is that these builtins can be reused by TurboFan directly in the future when we optimize apply better, and that we can also reuse the core logic in the handling of spread calls/constructs. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4587, v8:5269 LOG=N Review-Url: https://codereview.chromium.org/2932833002 Cr-Commit-Position: refs/heads/master@{#45826} Committed: https://chromium.googlesource.com/v8/v8/+/9385fd40e06975194fe80e3d645dcf1b9f88f50f

Patch Set 1 #

Patch Set 2 : s390 port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -283 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 11 chunks +45 lines, -141 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 11 chunks +46 lines, -142 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 3 chunks +38 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 3 chunks +38 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 6 months ago (2017-06-09 16:00:00 UTC) #1
john.yan
lgtm
3 years, 6 months ago (2017-06-09 16:12:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932833002/20001
3 years, 6 months ago (2017-06-09 16:53:34 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 17:13:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9385fd40e06975194fe80e3d645dcf1b9f8...

Powered by Google App Engine
This is Rietveld 408576698