Issue 2932793002: Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken with…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2932793002: Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken with… (Closed)

Created:
3 years, 6 months ago by terry

Modified:
3 years, 6 months ago

Reviewers:
Alan Knight, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation. R=alanknight@google.com,sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/3cbacefbe3567688b17c7cc4cd10a307847f5601

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

terry

Committed patchset #1 (id:1) manually as 3cbacefbe3567688b17c7cc4cd10a307847f5601 (presubmit successful).

3 years, 6 months ago (2017-06-09 03:44:40 UTC) #2

Message was sent while issue was closed.

lgtm