tools/dom/scripts/dartmetadata.py - Issue 2932793002: Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken with…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 2932793002: Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken with… (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/dartmetadata.py

diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py

index 25f00ce031c2944a404ccf11892bf741f945b115..6e77214afa861fa084a3139a3c15b4ca33de9048 100644

--- a/tools/dom/scripts/dartmetadata.py

+++ b/tools/dom/scripts/dartmetadata.py

@@ -192,8 +192,8 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {

'HTMLCanvasElement.getContext': [

- "@Creates('CanvasRenderingContext2D|RenderingContext')",

- "@Returns('CanvasRenderingContext2D|RenderingContext|Null')",

+ "@Creates('CanvasRenderingContext2D|RenderingContext|RenderingContext2')",

+ "@Returns('CanvasRenderingContext2D|RenderingContext|RenderingContext2|Null')",

'HTMLInputElement.valueAsDate': [